Skip to content

fix(deps): sync rmcp 0.10.0 and openssl-sys vendored with forge-core#296

Merged
namastex888 merged 1 commit into
devfrom
fix/openssl-vendored
Dec 5, 2025
Merged

fix(deps): sync rmcp 0.10.0 and openssl-sys vendored with forge-core#296
namastex888 merged 1 commit into
devfrom
fix/openssl-vendored

Conversation

@namastex888

Copy link
Copy Markdown
Contributor

Summary

  • Updates rmcp from 0.8.5 to 0.10.0 to match forge-core
  • Syncs with forge-core openssl-sys vendored feature for musl builds

Changes

  • Cargo.toml: rmcp 0.8.5 → 0.10.0
  • Cargo.lock: Updated dependencies

Test plan

  • CI passes
  • When merged, automation triggers forge-core pre-release
  • Linux musl build passes with vendored OpenSSL

- Update rmcp from 0.8.5 to 0.10.0 to match forge-core
- forge-core already has openssl-sys vendored feature for musl builds
@namastex888 namastex888 added the rc Release candidate - triggers RC automation label Dec 5, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @namastex888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on synchronizing key dependencies and build configurations to maintain consistency with the forge-core project. It updates the rmcp crate to version 0.10.0 and aligns the openssl-sys vendored feature for musl builds. These changes are crucial for ensuring a unified development environment and are a prerequisite for an upcoming forge-core pre-release.

Highlights

  • Dependency Update: The rmcp dependency has been updated from version "0.8.5" to "0.10.0" to align with the version used in forge-core.
  • Musl Build Synchronization: The openssl-sys vendored feature for musl builds has been synchronized to match the configuration within forge-core, ensuring consistent build environments.
  • Cargo.lock Updates: The Cargo.lock file has been updated to reflect the new dependency versions and includes new [[patch.unused]] entries for codex-app-server-protocol, codex-protocol, and mcp-types.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the rmcp dependency to version 0.10.0. However, the changes to Cargo.lock have introduced [patch.unused] sections. This indicates that there is some unused dependency patch configuration, likely in a .cargo/config.toml file, which should be removed to maintain a clean and understandable build configuration. I've added a specific comment regarding this.

Comment thread Cargo.lock
Comment on lines +7013 to +7026
[[patch.unused]]
name = "codex-app-server-protocol"
version = "0.63.0"
source = "git+https://github.com/namastexlabs/codex.git?branch=main#27dd137e257b3e2b1857ebb02113178e064722c7"

[[patch.unused]]
name = "codex-protocol"
version = "0.63.0"
source = "git+https://github.com/namastexlabs/codex.git?branch=main#27dd137e257b3e2b1857ebb02113178e064722c7"

[[patch.unused]]
name = "mcp-types"
version = "0.63.0"
source = "git+https://github.com/namastexlabs/codex.git?branch=main#27dd137e257b3e2b1857ebb02113178e064722c7"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These [patch.unused] sections were added by cargo because it found patch definitions that were not applied to any dependencies in the lockfile. This typically points to a stale or incorrect configuration in a .cargo/config.toml file.

To maintain a clean build configuration and prevent confusion, it would be best to locate and remove these unused patch definitions. It appears they are attempting to patch codex-app-server-protocol, codex-protocol, and mcp-types from a codex.git repository, but these dependencies are being resolved from forge-core.git instead.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml
Comment on lines 29 to +30
# forge-core workspace dependencies (required for dev-core mode)
rmcp = { version = "0.8.5" }
rmcp = { version = "0.10.0" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update rmcp lockfile entry to 0.10.0

Cargo.toml now requires rmcp 0.10.0, but Cargo.lock still pins rmcp/rmcp-macros to 0.5.0 (lines ~4100–4123). Any build that uses --locked or relies on the committed lockfile will either continue compiling against 0.5.0 or fail dependency resolution because the lock does not satisfy the new requirement. Please refresh the lockfile (e.g., cargo update -p rmcp) so the bump actually takes effect and matches forge-core.

Useful? React with 👍 / 👎.

@namastex888
namastex888 merged commit 6a5dd5d into dev Dec 5, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rc Release candidate - triggers RC automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant