fix(deps): sync rmcp 0.10.0 and openssl-sys vendored with forge-core#296
Conversation
- Update rmcp from 0.8.5 to 0.10.0 to match forge-core - forge-core already has openssl-sys vendored feature for musl builds
Summary of ChangesHello @namastex888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on synchronizing key dependencies and build configurations to maintain consistency with the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the rmcp dependency to version 0.10.0. However, the changes to Cargo.lock have introduced [patch.unused] sections. This indicates that there is some unused dependency patch configuration, likely in a .cargo/config.toml file, which should be removed to maintain a clean and understandable build configuration. I've added a specific comment regarding this.
| [[patch.unused]] | ||
| name = "codex-app-server-protocol" | ||
| version = "0.63.0" | ||
| source = "git+https://github.com/namastexlabs/codex.git?branch=main#27dd137e257b3e2b1857ebb02113178e064722c7" | ||
|
|
||
| [[patch.unused]] | ||
| name = "codex-protocol" | ||
| version = "0.63.0" | ||
| source = "git+https://github.com/namastexlabs/codex.git?branch=main#27dd137e257b3e2b1857ebb02113178e064722c7" | ||
|
|
||
| [[patch.unused]] | ||
| name = "mcp-types" | ||
| version = "0.63.0" | ||
| source = "git+https://github.com/namastexlabs/codex.git?branch=main#27dd137e257b3e2b1857ebb02113178e064722c7" |
There was a problem hiding this comment.
These [patch.unused] sections were added by cargo because it found patch definitions that were not applied to any dependencies in the lockfile. This typically points to a stale or incorrect configuration in a .cargo/config.toml file.
To maintain a clean build configuration and prevent confusion, it would be best to locate and remove these unused patch definitions. It appears they are attempting to patch codex-app-server-protocol, codex-protocol, and mcp-types from a codex.git repository, but these dependencies are being resolved from forge-core.git instead.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # forge-core workspace dependencies (required for dev-core mode) | ||
| rmcp = { version = "0.8.5" } | ||
| rmcp = { version = "0.10.0" } |
There was a problem hiding this comment.
Update rmcp lockfile entry to 0.10.0
Cargo.toml now requires rmcp 0.10.0, but Cargo.lock still pins rmcp/rmcp-macros to 0.5.0 (lines ~4100–4123). Any build that uses --locked or relies on the committed lockfile will either continue compiling against 0.5.0 or fail dependency resolution because the lock does not satisfy the new requirement. Please refresh the lockfile (e.g., cargo update -p rmcp) so the bump actually takes effect and matches forge-core.
Useful? React with 👍 / 👎.
Summary
Changes
Cargo.toml: rmcp 0.8.5 → 0.10.0Cargo.lock: Updated dependenciesTest plan