Release v0.8.7-rc.2 - forge-core sync with rmcp 0.10.0#301
Conversation
Summary of ChangesHello @namastex888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on preparing for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates package versions to 0.8.7-rc.2 and syncs the forge-core dependency to tag v0.8.7-rc.2. The changes are consistent with preparing for a new release. I've identified a version inconsistency with the forge-core dependency where the crate versions in Cargo.lock do not match the new git tag. I've also included a suggestion to enhance the maintainability of your git dependencies for the long term.
| version = "0.8.7-rc.1" | ||
| source = "git+https://github.com/namastexlabs/forge-core.git?tag=v0.8.7-rc.1#3145436881177bee5d2be17b74ec05dbfbe91b44" | ||
| source = "git+https://github.com/namastexlabs/forge-core.git?tag=v0.8.7-rc.2#0b8ecf4fc2f78eb4e99499dd8aa930499f84ff2d" |
There was a problem hiding this comment.
There's a version mismatch here. The package version is 0.8.7-rc.1, but the git tag in the source URL is v0.8.7-rc.2. This suggests that the crate versions within the forge-core repository were not bumped to match the new tag. For release consistency, the crate versions should match the git tag version. This seems to be the case for all forge-core dependencies in this file (e.g., deployment, executors, etc.). Please ensure versions are synchronized in the forge-core repository for tag v0.8.7-rc.2.
| db = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } | ||
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } | ||
| server = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } | ||
| deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } | ||
| local-deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } | ||
| executors = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } | ||
| utils = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } |
There was a problem hiding this comment.
These repeated git dependency declarations with tags can be hard to maintain. While the bump-forge-core.sh script helps, you might consider using a git submodule for forge-core.
With a submodule, you could replace these git dependencies with path dependencies, like this:
# In forge-app/Cargo.toml
db = { path = "../path/to/forge-core/db" }
services = { path = "../path/to/forge-core/services" }
# ... and so onThis would tie the dependency version to a single commit hash of the submodule, making it easier to manage and update all forge-core crates at once by just updating the submodule pointer. This would also simplify your release automation scripts.
Summary
0.8.7-rc.2rmcp = "0.10.0"(was 0.8.5)v0.8.7-rc.2Changes
Test plan
nexttag