Skip to content

fix: upgrade rmcp to 0.10.0 (release RC)#302

Closed
namastex888 wants to merge 2 commits into
mainfrom
fix/rmcp-0.10.0-upgrade
Closed

fix: upgrade rmcp to 0.10.0 (release RC)#302
namastex888 wants to merge 2 commits into
mainfrom
fix/rmcp-0.10.0-upgrade

Conversation

@namastex888

Copy link
Copy Markdown
Contributor

Summary

  • Updates all forge-core dependencies to v0.8.7-rc.4
  • This version includes the fix for rmcp version mismatch (server crate now uses workspace rmcp 0.10.0 instead of overriding to 0.5.0)

Root Cause Fixed

The build was failing because forge-core/crates/server/Cargo.toml was overriding rmcp to version 0.5.0, which lacks the title, icons, and website_url fields used in the code. This has been fixed in forge-core PR #31 and tagged as v0.8.7-rc.4.

Test plan

  • cargo check passes locally
  • CI builds pass on all platforms (macOS, Linux, Windows)
  • Release artifacts are generated correctly

@namastex888 namastex888 added the rc Release candidate - triggers RC automation label Dec 9, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @namastex888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build failure by upgrading the forge-core dependencies to their latest release candidate, v0.8.7-rc.4. This update specifically rectifies an outdated rmcp dependency that was causing missing fields and preventing successful builds, ensuring compatibility and stability across the project's components.

Highlights

  • Forge-Core Dependency Update: All forge-core dependencies across the project have been updated to version v0.8.7-rc.4.
  • RMCP Crate Upgrade: The rmcp and rmcp-macros crates have been upgraded from version 0.5.0 to 0.10.0.
  • Build Failure Resolution: This update specifically fixes a build failure caused by an rmcp version mismatch in forge-core/crates/server/Cargo.toml, which previously lacked necessary fields like title, icons, and website_url.
  • Dependency Adjustments: Minor adjustments were made to other dependencies in Cargo.lock, including simplifying itertools version specifications, downgrading windows-sys to 0.45.0, and replacing the paste dependency with pastey within rmcp.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates forge-core dependencies to v0.8.7-rc.4 to fix a build failure caused by an rmcp version mismatch. The changes in Cargo.toml and Cargo.lock are correct and address the issue described.

My main feedback is to improve the maintainability of your Cargo.toml files. Currently, the forge-core git dependencies are repeated in multiple files, which makes updates cumbersome and error-prone. I've suggested using workspace dependencies to centralize these definitions in your root Cargo.toml. This will make future dependency bumps much simpler and less reliant on scripts.

Comment thread forge-app/Cargo.toml
Comment on lines +53 to +59
db = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
server = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
local-deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
executors = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
utils = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These git dependencies are repeated across multiple Cargo.toml files (forge-app/Cargo.toml, forge-extensions/config/Cargo.toml). This makes updating the forge-core tag tedious and error-prone, as evidenced by the existence of the scripts/bump-forge-core.sh script.

To improve maintainability, you can define these dependencies in the [workspace.dependencies] table in the root Cargo.toml file. This centralizes the dependency definition, so you only need to update the tag in one place.

In your root Cargo.toml:

[workspace.dependencies]
# ... other dependencies
db = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
server = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
local-deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
executors = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
utils = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }

Then, in this file, you can simplify the dependencies to:

db = { workspace = true }
services = { workspace = true }
server = { workspace = true }
deployment = { workspace = true }
local-deployment = { workspace = true }
executors = { workspace = true }
utils = { workspace = true }

This would make version bumps much easier and less reliant on scripts.

Suggested change
db = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
server = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
local-deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
executors = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
utils = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
db = { workspace = true }
services = { workspace = true }
server = { workspace = true }
deployment = { workspace = true }
local-deployment = { workspace = true }
executors = { workspace = true }
utils = { workspace = true }

chrono = { version = "0.4", features = ["serde"] }
forge-omni = { path = "../omni" }
services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" }
services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the dependencies in forge-app/Cargo.toml, this git dependency should be defined in the [workspace.dependencies] table in the root Cargo.toml to centralize version management and improve maintainability. You can then reference it here using services = { workspace = true }.

Suggested change
services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
services = { workspace = true }

Updates all forge-core git dependencies to use tag v0.8.7-rc.4 which
contains the fix for rmcp version mismatch (server crate now uses
workspace rmcp 0.10.0 instead of overriding to 0.5.0).
- Add pre-commit hook to auto-stage forge-core changes
- Add prepare-commit-msg hook to sync commit messages
- Update pre-push hook to push forge-core first
- Add create-twin-pr.yml workflow for automatic twin PR creation
- Add merge-twin-pr.yml workflow for automatic twin PR merge
- Update Makefile to install all git hooks in dev-core
@namastex888
namastex888 force-pushed the fix/rmcp-0.10.0-upgrade branch from c410734 to 306e6b1 Compare December 9, 2025 02:55
@namastex888 namastex888 closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rc Release candidate - triggers RC automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant