fix: upgrade rmcp to 0.10.0 (release RC)#302
Conversation
Summary of ChangesHello @namastex888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build failure by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates forge-core dependencies to v0.8.7-rc.4 to fix a build failure caused by an rmcp version mismatch. The changes in Cargo.toml and Cargo.lock are correct and address the issue described.
My main feedback is to improve the maintainability of your Cargo.toml files. Currently, the forge-core git dependencies are repeated in multiple files, which makes updates cumbersome and error-prone. I've suggested using workspace dependencies to centralize these definitions in your root Cargo.toml. This will make future dependency bumps much simpler and less reliant on scripts.
| db = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | ||
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | ||
| server = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | ||
| deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | ||
| local-deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | ||
| executors = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | ||
| utils = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } |
There was a problem hiding this comment.
These git dependencies are repeated across multiple Cargo.toml files (forge-app/Cargo.toml, forge-extensions/config/Cargo.toml). This makes updating the forge-core tag tedious and error-prone, as evidenced by the existence of the scripts/bump-forge-core.sh script.
To improve maintainability, you can define these dependencies in the [workspace.dependencies] table in the root Cargo.toml file. This centralizes the dependency definition, so you only need to update the tag in one place.
In your root Cargo.toml:
[workspace.dependencies]
# ... other dependencies
db = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
server = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
local-deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
executors = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }
utils = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" }Then, in this file, you can simplify the dependencies to:
db = { workspace = true }
services = { workspace = true }
server = { workspace = true }
deployment = { workspace = true }
local-deployment = { workspace = true }
executors = { workspace = true }
utils = { workspace = true }This would make version bumps much easier and less reliant on scripts.
| db = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | |
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | |
| server = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | |
| deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | |
| local-deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | |
| executors = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | |
| utils = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | |
| db = { workspace = true } | |
| services = { workspace = true } | |
| server = { workspace = true } | |
| deployment = { workspace = true } | |
| local-deployment = { workspace = true } | |
| executors = { workspace = true } | |
| utils = { workspace = true } |
| chrono = { version = "0.4", features = ["serde"] } | ||
| forge-omni = { path = "../omni" } | ||
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } | ||
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } |
There was a problem hiding this comment.
Similar to the dependencies in forge-app/Cargo.toml, this git dependency should be defined in the [workspace.dependencies] table in the root Cargo.toml to centralize version management and improve maintainability. You can then reference it here using services = { workspace = true }.
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.4" } | |
| services = { workspace = true } |
Updates all forge-core git dependencies to use tag v0.8.7-rc.4 which contains the fix for rmcp version mismatch (server crate now uses workspace rmcp 0.10.0 instead of overriding to 0.5.0).
- Add pre-commit hook to auto-stage forge-core changes - Add prepare-commit-msg hook to sync commit messages - Update pre-push hook to push forge-core first - Add create-twin-pr.yml workflow for automatic twin PR creation - Add merge-twin-pr.yml workflow for automatic twin PR merge - Update Makefile to install all git hooks in dev-core
c410734 to
306e6b1
Compare
Summary
Root Cause Fixed
The build was failing because
forge-core/crates/server/Cargo.tomlwas overriding rmcp to version 0.5.0, which lacks thetitle,icons, andwebsite_urlfields used in the code. This has been fixed in forge-core PR #31 and tagged as v0.8.7-rc.4.Test plan
cargo checkpasses locally