dev#303
Conversation
Release Candidate v0.8.7-rc.1
Release v0.8.7-rc.2 - forge-core sync with rmcp 0.10.0
Summary of ChangesHello @namastex888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on synchronizing version numbers across the project's components. It updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be for releasing version 0.8.7-rc.3, but it is incomplete. While the package.json files and forge-core dependencies have been updated, the crate versions for forge-app and forge-config in their respective Cargo.toml files remain at 0.8.7-rc.2. This version inconsistency across the monorepo can lead to build failures, incorrect dependency resolution, and confusion during releases. It's critical that all packages intended for a release are versioned uniformly.
For future pull requests, please provide a descriptive title and a summary of changes in the description to help reviewers understand the context and purpose of the changes.
| db = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.3" } | ||
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.3" } | ||
| server = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.3" } | ||
| deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.3" } | ||
| local-deployment = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.3" } | ||
| executors = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.3" } | ||
| utils = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.3" } |
There was a problem hiding this comment.
Inconsistent Crate Version
While the forge-core dependency tags are correctly updated to v0.8.7-rc.3, the version of this crate (forge-app) itself has not been updated. It remains at 0.8.7-rc.2 (on line 3).
This is inconsistent with the version bumps to 0.8.7-rc.3 in the package.json files across the repository. For a consistent release, all workspace packages should be versioned together.
Please update the version of this crate to 0.8.7-rc.3 as well. The scripts/unified-release.cjs script seems designed to handle this automatically and should probably be used to ensure consistency.
| chrono = { version = "0.4", features = ["serde"] } | ||
| forge-omni = { path = "../omni" } | ||
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.2" } | ||
| services = { git = "https://github.com/namastexlabs/forge-core.git", tag = "v0.8.7-rc.3" } |
There was a problem hiding this comment.
Inconsistent Crate Version
The forge-core dependency tag has been updated to v0.8.7-rc.3, but the version of this crate (forge-config) is still 0.8.7-rc.2 (on line 3).
To maintain consistency across the monorepo for this release candidate, this crate's version should also be bumped to 0.8.7-rc.3, matching the changes in the package.json files.
Please ensure all packages are versioned consistently. Using the scripts/unified-release.cjs script might help prevent such inconsistencies in the future.
No description provided.