fix(ci): disable incremental compilation for sccache#306
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
…r ownership Two fixes for CI issues: 1. sccache incompatibility: Add CARGO_INCREMENTAL=0 because sccache doesn't work with Cargo's incremental compilation. The forge-builder Docker container has CARGO_INCREMENTAL=1 set, which caused builds to fail. 2. Container ownership: Add cleanup step to fix file ownership at end of Linux container builds. Docker containers run as root, creating files that the runner user can't clean up, causing subsequent jobs (e2e, test) to fail with EACCES permission errors.
namastex888
force-pushed
the
fix/sccache-incremental
branch
from
December 9, 2025 23:56
26cbece to
dc4a621
Compare
Previously, release.yml created tags in forge-core pointing at main HEAD without updating the workspace version first. This caused version mismatch where crates showed old version (e.g., 0.8.7-rc.4) even from newer tags (e.g., v0.8.7-rc.11). Now triggers sync-version-from-forge workflow in forge-core which: 1. Updates [workspace.package] version using cargo set-version 2. Commits the change 3. Creates annotated tag pointing at the versioned commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues Fixed
1. sccache CARGO_INCREMENTAL conflict
sccache: incremental compilation is prohibitedCARGO_INCREMENTAL=1setCARGO_INCREMENTAL=0to sccache configuration2. forge-core version mismatch
v0.8.7-rc.4even fromv0.8.7-rc.11tagsync-version-from-forgeworkflow before creating tag3. Linux container file ownership
chown -R 1000:1000cleanup step at end of buildTest plan
rclabel to trigger RC.12