dev

[namastex888]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @namastex888, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort by renaming all internal forge-core crates with a forge-core- prefix. This change improves code organization and reduces the likelihood of naming collisions. Concurrently, the project's reliance on a custom ts-rs git dependency has been transitioned to a new ts-rs-forge crate available on crates.io, aiming for more robust and standard dependency resolution. Supporting build and release scripts have also been updated to align with these changes, introducing better development workflow checks and more reliable version management.

Highlights

• Crate Renaming: Internal forge-core crates have been systematically renamed with a forge-core- prefix (e.g., db became forge-core-db, services became forge-core-services) to enhance clarity and prevent naming conflicts across the project.
• Dependency Migration: The ts-rs dependency has been migrated from a custom git repository fork to a new ts-rs-forge crate published on crates.io, standardizing dependency management and simplifying future updates.
• Build System Enhancements: The Makefile and release automation scripts have been updated to reflect the new crate naming conventions, improve the dev-core workflow with new safety checks for uncommitted changes, and streamline Cargo.toml version updates by replacing cargo-edit with direct file manipulation.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/auto-version-bump.yml
  • .github/workflows/release.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant refactoring, primarily renaming the internal forge-core crates to have a forge-core- prefix for clarity. This change is propagated throughout the codebase, including Cargo.toml files, Cargo.lock, and use statements in the Rust source. Additionally, the dev-core development workflow in the Makefile has been substantially improved with better branch handling and safety checks. The release script has also been made more robust.

I've found a couple of critical issues in the example files where the new crate paths seem to have been applied incorrectly, which will likely lead to compilation failures. Other than that, the refactoring appears to be consistent and well-implemented.

[gemini-code-assist]

The path forge_app_lib::forge_core_services::ForgeServices appears to be incorrect. forge_core_services is a dependency of the forge_app_lib crate, not a module within it that can be accessed this way from an external example. The ForgeServices struct you likely want to instantiate is the wrapper defined in forge-app/src/services/mod.rs. The original path forge_app_lib::services::ForgeServices was correct. This change will likely cause a compilation error.

Suggested change

	match forge_app_lib::forge_core_services::ForgeServices::new().await {
	match forge_app_lib::services::ForgeServices::new().await {

[gemini-code-assist]

The path forge_app_lib::forge_core_services::genie_profiles::GenieProfileLoader seems incorrect. genie_profiles is a module within forge_app_lib::services, and forge_core_services is a dependency, not a module. The correct path to GenieProfileLoader should be through the services module. This change will likely cause a compilation error.

Suggested change

	let loader = forge_app_lib::forge_core_services::genie_profiles::GenieProfileLoader::new(&workspace_root);
	let loader = forge_app_lib::services::genie_profiles::GenieProfileLoader::new(&workspace_root);