fix(ci): use inputs.version for npm publish check#322
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ -n "${{ inputs.version }}" ]]; then | ||
| VER="${{ inputs.version }}" | ||
| echo "Using version from workflow input: $VER" | ||
| else | ||
| VER=$(node -e "console.log(require('./npx-cli/package.json').version)") |
There was a problem hiding this comment.
The new block at lines 529-533 sets VER from the workflow input, but the publish job still checks out the original ref (line 407) where npx-cli/package.json remains at the pre-bump version because the release workflow invokes this reusable workflow before the bumped commit is available. In release runs, npm view now looks for the bumped version while npm publish packages the old one, so publish will attempt to republish an already existing version and fail. Align the checkout or package.json to the bumped version before publishing.
Useful? React with 👍 / 👎.
The build and publish jobs were checking out the default ref (pre-bump),
causing them to build and publish the OLD version instead of the NEW one.
Changes:
1. Build jobs: checkout v${{ inputs.version }} tag (created by version job)
2. Publish job: same checkout ref as build jobs
3. Publish job: use inputs.version for npm version check
This ensures:
- Build compiles the correct version code
- npm publish publishes the correct version
07e7927 to
15c9a2c
Compare
Comprehensive analysis of 187 commits behind BloopAI/vibe-kanban (v0.0.115 → v0.0.138). Tech Council reviewed (2/3 MODIFY). Key findings: - 5 critical commits (SQLite perf, memory fix, security) - 26 high-value cherry-picks (cleanup + bug fixes) - 35 evaluate (executors, SaaS features for team collab) - 90 skip (branding, i18n, UI polish) - 6 implementation phases defined New crates in upstream: crates/remote, crates/review Re-evaluated for SaaS/team collaboration direction.
|
@codex review this pr |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Bug Fix
The publish job was checking if the OLD version exists on npm instead of the NEW version.
Root cause: The publish job reads version from
npx-cli/package.jsonat checkout time, but at that point the repo still has the pre-bump version (rc.38). The version job bumps to rc.39 and pushes, but the publish job's checkout happened before that push.Fix: Use
inputs.versionpassed fromrelease.ymlwhich has the correct NEW version.Impact: This caused rc.39 npm publish to be skipped because it checked if rc.38 exists (it does).
Test plan
rclabel to trigger rc.40 release@automagik/forge@0.8.7-rc.40published to npm