Skip to content

revert: feat: check binary compatibility when there are duplicate classes on the classpath.#1311

Merged
autonomousapps merged 1 commit intomainfrom
trobalik.revert-binary-compat-check
Nov 16, 2024
Merged

revert: feat: check binary compatibility when there are duplicate classes on the classpath.#1311
autonomousapps merged 1 commit intomainfrom
trobalik.revert-binary-compat-check

Conversation

@autonomousapps
Copy link
Copy Markdown
Owner

@autonomousapps autonomousapps commented Nov 15, 2024

This dramatically increased size (more than 2x) of this plugin's outputs on disk, and was leading to additional follow-up changes that felt increasingly risky for a marginal use-case. For now, users will have to just rely on the existing Warning feature for notification about the duplicate classes issue.

#1306
#1310

@github-actions
Copy link
Copy Markdown

❌ Test workflow failed:

* Root buildHealth         : https://gradle.com/s/53umwmmm2gpp2
* TestKit buildHealth      : https://gradle.com/s/hh6jza3k4chti
* Non-functional tests     : https://gradle.com/s/ndpx7wwxbb2si
* TestKit check            : https://gradle.com/s/gkni3el5taqb2
* JVM functional tests     : https://gradle.com/s/6kexn7r76wrvk
* Android functional tests : 

@autonomousapps autonomousapps force-pushed the trobalik.revert-binary-compat-check branch from e376309 to c69a9d2 Compare November 15, 2024 19:51
@github-actions
Copy link
Copy Markdown

❌ Test workflow failed:

* Root buildHealth         : https://gradle.com/s/5hc2fpf7ibpcq
* TestKit buildHealth      : https://gradle.com/s/xqijbbuoontx4
* Non-functional tests     : https://gradle.com/s/hfvpg7yw6wmow
* TestKit check            : https://gradle.com/s/cqudakuedvjlk
* JVM functional tests     : https://gradle.com/s/2ofspacdftl4i
* Android functional tests : https://gradle.com/s/2z5xywofcjqm4

@autonomousapps autonomousapps force-pushed the trobalik.revert-binary-compat-check branch from c69a9d2 to 8670790 Compare November 15, 2024 23:34
@autonomousapps autonomousapps marked this pull request as ready for review November 16, 2024 00:34
@autonomousapps autonomousapps merged commit 8115dfd into main Nov 16, 2024
@autonomousapps autonomousapps deleted the trobalik.revert-binary-compat-check branch November 16, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant