fix: exceptions, main->test visibility, reason for android lint jars.#1708
Merged
Conversation
autonomousapps
commented
May 20, 2026
autonomousapps
commented
May 20, 2026
Owner
Author
There was a problem hiding this comment.
Separate bug discovered when using reason.
Job Summary for GradleTest :: gradle
|
autonomousapps
force-pushed
the
trobalik.bugs
branch
from
6df33b2 to
b89fe02
Compare
Job Summary for GradleTest :: gradle
|
autonomousapps
force-pushed
the
trobalik.bugs
branch
from
d462045 to
51fed2b
Compare
1. reason output said "implies implementation" when it should have been "implies runtimeOnly" in the android lint jar case. 2. The new "exceptions are special" handling was over-eager and flagging things that only referenced exceptions. We only want to flag things that provide the exception types. 3. MutableSet<Usage>.simplify(visibility, bucket) in StandardTransform wasn't properly handling the case when a usage was visible on both compile and runtime classpaths. In such a case, we can filter out all usages.
autonomousapps
force-pushed
the
trobalik.bugs
branch
from
51fed2b to
1a581e1
Compare
autonomousapps
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three separate bugfixes:
reasonoutput said "implies implementation" when it should have been "implies runtimeOnly" in the android lint jar case.MutableSet<Usage>.simplify(visibility, bucket)inStandardTransformwasn't properly handling the case when a usage was visible on both compile and runtime classpaths. In such a case, we can filter out all usages.