fix: improve handling of Android product flavors.#1742
Merged
Conversation
Job Summary for GradleTest :: gradle
|
autonomousapps
force-pushed
the
trobalik.product-flavors
branch
from
73746de to
002ad35
Compare
autonomousapps
changed the title
Job Summary for GradleTest :: gradle
|
autonomousapps
force-pushed
the
trobalik.product-flavors
branch
from
002ad35 to
f811067
Compare
autonomousapps
force-pushed
the
trobalik.product-flavors
branch
from
f811067 to
77c111d
Compare
Specifically when there's a single remove-advice and multiple add-advice for the same dependency, on the same buildType but multiple product flavors (or vice-versa). This can happen when there's a declaration on 'debugImplementation' but it should be on 'debugRuntimeOnly'. We were getting advice to *move* it to 'flavorDebugRuntimeOnly', which is inaccurate."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.