Skip to content

Commit 04a0ccb

Browse files
committed
Merge remote-tracking branch 'origin/main' into separate-data-packages-for-versions
# Conflicts: # .github/workflows/python-package.yml
2 parents 75ba701 + 72d6948 commit 04a0ccb

7 files changed

Lines changed: 17 additions & 6 deletions

File tree

.github/workflows/codeql-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030

3131
steps:
3232
- name: Checkout repository
33-
uses: actions/checkout@v5
33+
uses: actions/checkout@v6
3434
with:
3535
# We must fetch at least the immediate parents so that if this is
3636
# a pull request then we can checkout the head.

.github/workflows/python-package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
matrix:
1717
python-version: ["3.11"]
1818
steps:
19-
- uses: actions/checkout@v5
19+
- uses: actions/checkout@v6
2020
- name: Set up Python ${{ matrix.python-version }}
2121
uses: actions/setup-python@v6
2222
with:

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
environment: pypi
1515
steps:
1616
- name: Checkout
17-
uses: actions/checkout@v5
17+
uses: actions/checkout@v6
1818
with:
1919
fetch-depth: 0
2020

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
run:
1414
working-directory: pythonbible
1515
steps:
16-
- uses: actions/checkout@v5
16+
- uses: actions/checkout@v6
1717
- name: Install uv
1818
uses: astral-sh/setup-uv@v7
1919
- name: Setup NOX

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ repos:
3838
hooks:
3939
- id: mypy
4040
- repo: https://github.com/sourcery-ai/sourcery
41-
rev: v1.40.1b10
41+
rev: v1.41.1
4242
hooks:
4343
- id: sourcery
4444
args: [--diff=git diff HEAD, --no-summary]

pythonbible/pythonbible/verses.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
24,
2525
21,
2626
16,
27-
28,
27+
27,
2828
34,
2929
38,
3030
19,

pythonbible/tests/counters_test.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,3 +210,14 @@ def test_count_verses_string() -> None:
210210

211211
# Then the count is correct
212212
assert number_of_verses == 1 + 1 + (3 + 1)
213+
214+
215+
def test_count_verses_genesis_17() -> None:
216+
# To address https://github.com/avendesora/pythonbible/issues/223
217+
reference: str = "Genesis 17"
218+
219+
# Retrieve number of verses in Genesis 17
220+
number_of_verses: int = bible.count_verses(reference) # type: ignore[arg-type]
221+
222+
# Genesis 17 should have 27 verses
223+
assert number_of_verses == 27

0 commit comments

Comments
 (0)