Skip to content

Commit bbb6ad1

Browse files
authored
Fix Genesis 17 verse count to 27 (#224)
* test: add failing test for number of verses in Genesis 17 * fix: update verse count in Genesis 17 from 28 to 27 * fix(test): fix type checking for count_verses(str)
1 parent cf4bd2b commit bbb6ad1

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

pythonbible/verses.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
24,
2525
21,
2626
16,
27-
28,
27+
27,
2828
34,
2929
38,
3030
19,

tests/counters_test.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,3 +210,14 @@ def test_count_verses_string() -> None:
210210

211211
# Then the count is correct
212212
assert number_of_verses == 1 + 1 + (3 + 1)
213+
214+
215+
def test_count_verses_genesis_17() -> None:
216+
# To address https://github.com/avendesora/pythonbible/issues/223
217+
reference: str = "Genesis 17"
218+
219+
# Retrieve number of verses in Genesis 17
220+
number_of_verses: int = bible.count_verses(reference) # type: ignore[arg-type]
221+
222+
# Genesis 17 should have 27 verses
223+
assert number_of_verses == 27

0 commit comments

Comments
 (0)