fix(velocity): extend canonical model format to support experimental labels like "owl-alpha"#1194
Open
behnamnba1900-art wants to merge 1 commit into
Conversation
…labels like "owl-alpha" - Update CANONICAL_MODEL regex in velocity-log.js, error-log.js and the CSV test from /^[a-z]+-\d+\.\d+$/ to /^[a-z]+-[a-z0-9.]+$/ so both <family>-<major.minor> (e.g. opus-4.8) and <family>-<label> (e.g. owl-alpha) are accepted. - Update validator messages, comments, and docs/puzzle-velocity.md + errors-schema.md to document the extended convention. - "owl-alpha" (historical row) is now treated as valid; no DB/CSV data change needed. - Resolves the standing red test / drift reported in avidrucker#1193 by choosing the "intentional non-Claude/experimental model" path and widening the convention. Closes avidrucker#1193
Author
|
Checked out #1193. The "owl-alpha" entry was the one triggering the model naming violation in the puzzle-velocity-csv test (even after the notice-not-prevent change from #1184). I went with extending the canonical format instead of trying to scrub the historical row from the DB/CSV. Updated the regex in velocity-log.js and error-log.js (and the report test) to also accept - forms like "owl-alpha" alongside the versioned ones. Synced the docs and now the current data passes cleanly with zero non-canonical models reported. Felt like the right long-term call given the existing comments about models being an open-growth list. If you'd prefer to treat it as bad data and clean the row instead, just say the word and I can adjust. Closes #1193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1193
Decision taken: chose path 2 (intentional non-Claude / experimental model support) rather than editing the source DB row.
Changes:
CANONICAL_MODELregex inscripts/velocity-log.jsandscripts/error-log.js(and the report test) to/^[a-z]+-[a-z0-9.]+$/.This accepts both the original
<family>-<major>.<minor>(e.g.opus-4.8,sonnet-4.6) and labels likeowl-alpha.docs/puzzle-velocity.md+docs/errors-schema.md.This makes the standing red / drift go away while keeping the notice-not-prevent philosophy from #1184 for future model drift.
Tested locally: the specific test logic now accepts the row; no other non-canonical models were present.