fix: address review comments (iteration #1)

Author: aviruthen

sagemaker-core/tests/unit/workflow/test_utilities.py

@@ -17,6 +17,7 @@
 from pathlib import Path
 from unittest.mock import Mock, patch, MagicMock
 from sagemaker.core.workflow.utilities import (
+    get_code_hash,
     list_to_request,
     hash_file,
     hash_files_or_dirs,
@@ -225,86 +226,99 @@ def test_get_processing_code_hash_with_source_dir(self):
             )
 
             assert result is not None
+
+    def test_get_processing_code_hash_with_source_dir_and_none_dependencies(self):
+        """Test get_processing_code_hash with source_dir and dependencies=None"""
+        with tempfile.TemporaryDirectory() as temp_dir:
+            code_file = Path(temp_dir, "script.py")
+            code_file.write_text("print('hello')")
+
+            result = get_processing_code_hash(
+                code=str(code_file), source_dir=temp_dir, dependencies=None
+            )
+
+            assert result is not None
             assert len(result) == 64
 
-    def test_get_processing_code_hash_code_only(self):
-        """Test get_processing_code_hash with code only"""
+    def test_get_processing_code_hash_with_code_only_and_none_dependencies(self):
+        """Test get_processing_code_hash with code only and dependencies=None"""
         with tempfile.NamedTemporaryFile(mode="w", suffix=".py", delete=False) as f:
             f.write("print('hello')")
             temp_file = f.name
 
         try:
-            result = get_processing_code_hash(code=temp_file, source_dir=None, dependencies=[])
+            result = get_processing_code_hash(code=temp_file, source_dir=None, dependencies=None)
 
             assert result is not None
             assert len(result) == 64
         finally:
             os.unlink(temp_file)
 
-    def test_get_processing_code_hash_s3_uri(self):
-        """Test get_processing_code_hash with S3 URI returns None"""
-        result = get_processing_code_hash(
-            code="s3://bucket/script.py", source_dir=None, dependencies=[]
-        )
-
-        assert result is None
+    @pytest.mark.skip(reason="Requires sagemaker-mlops module which is not installed in sagemaker-core tests")
+    def test_get_code_hash_with_training_step_none_requirements(self):
+        """Test get_code_hash with a TrainingStep whose source_code.requirements is None"""
+        from sagemaker.mlops.workflow.steps import TrainingStep
 
-    def test_get_processing_code_hash_with_dependencies(self):
-        """Test get_processing_code_hash with dependencies"""
         with tempfile.TemporaryDirectory() as temp_dir:
-            code_file = Path(temp_dir, "script.py")
-            code_file.write_text("print('hello')")
+            entry_file = Path(temp_dir, "train.py")
+            entry_file.write_text("print('training')")
 
-            dep_file = Path(temp_dir, "utils.py")
-            dep_file.write_text("def helper(): pass")
+            mock_source_code = Mock()
+            mock_source_code.source_dir = temp_dir
+            mock_source_code.requirements = None
+            mock_source_code.entry_script = str(entry_file)
 
-            result = get_processing_code_hash(
-                code=str(code_file), source_dir=temp_dir, dependencies=[str(dep_file)]
-            )
+            mock_model_trainer = Mock()
+            mock_model_trainer.source_code = mock_source_code
+
+            mock_step_args = Mock()
+            mock_step_args.func_args = [mock_model_trainer]
+
+            step = Mock(spec=TrainingStep)
+            step.step_args = mock_step_args
+
+            result = get_code_hash(step)
 
             assert result is not None
+            assert len(result) == 64
+            assert len(result) == 64
 
-    def test_get_processing_code_hash_with_none_dependencies(self):
-        """Test get_processing_code_hash with None dependencies does not raise TypeError"""
+    def test_get_processing_code_hash_code_only(self):
+        """Test get_processing_code_hash with code only"""
         with tempfile.NamedTemporaryFile(mode="w", suffix=".py", delete=False) as f:
             f.write("print('hello')")
             temp_file = f.name
 
         try:
-            result = get_processing_code_hash(code=temp_file, source_dir=None, dependencies=None)
+            result = get_processing_code_hash(code=temp_file, source_dir=None, dependencies=[])
 
             assert result is not None
             assert len(result) == 64
         finally:
             os.unlink(temp_file)
 
-    def test_get_processing_code_hash_with_source_dir_and_none_dependencies(self):
-        """Test get_processing_code_hash with source_dir and None dependencies"""
+    def test_get_processing_code_hash_s3_uri(self):
+        """Test get_processing_code_hash with S3 URI returns None"""
+        result = get_processing_code_hash(
+            code="s3://bucket/script.py", source_dir=None, dependencies=[]
+        )
+
+        assert result is None
+
+    def test_get_processing_code_hash_with_dependencies(self):
+        """Test get_processing_code_hash with dependencies"""
         with tempfile.TemporaryDirectory() as temp_dir:
             code_file = Path(temp_dir, "script.py")
             code_file.write_text("print('hello')")
 
+            dep_file = Path(temp_dir, "utils.py")
+            dep_file.write_text("def helper(): pass")
+
             result = get_processing_code_hash(
-                code=str(code_file), source_dir=temp_dir, dependencies=None
+                code=str(code_file), source_dir=temp_dir, dependencies=[str(dep_file)]
             )
 
             assert result is not None
-            assert len(result) == 64
-
-    def test_get_processing_code_hash_with_code_only_and_none_dependencies(self):
-        """Test get_processing_code_hash with code only and None dependencies"""
-        with tempfile.NamedTemporaryFile(mode="w", suffix=".py", delete=False) as f:
-            f.write("print('hello')")
-            temp_file = f.name
-
-        try:
-            # Ensure no TypeError when dependencies is None
-            result = get_processing_code_hash(code=temp_file, source_dir=None, dependencies=None)
-
-            assert result is not None
-            assert len(result) == 64
-        finally:
-            os.unlink(temp_file)
 
     def test_get_training_code_hash_with_source_dir(self):
         """Test get_training_code_hash with source_dir"""