fix: Pipeline TypeError: can only concatenate list (not "NoneType") to list Using Sou (5518)

Author: aviruthen

sagemaker-core/tests/unit/workflow/test_utilities.py

@@ -24,6 +24,7 @@
     get_processing_dependencies,
     get_processing_code_hash,
     get_training_code_hash,
+    get_code_hash,
     validate_step_args_input,
     override_pipeline_parameter_var,
     trim_request_dict,
@@ -285,6 +286,20 @@ def test_get_training_code_hash_with_source_dir(self):
             assert len(result_with_deps) == 64
             assert result_no_deps != result_with_deps
 
+    def test_get_training_code_hash_with_source_dir_and_none_dependencies(self):
+        """Test get_training_code_hash with source_dir and None dependencies does not raise TypeError"""
+        with tempfile.TemporaryDirectory() as temp_dir:
+            entry_file = Path(temp_dir, "train.py")
+            entry_file.write_text("print('training')")
+
+            # This should NOT raise TypeError: can only concatenate list (not "NoneType") to list
+            result = get_training_code_hash(
+                entry_point=str(entry_file), source_dir=temp_dir, dependencies=None
+            )
+
+            assert result is not None
+            assert len(result) == 64
+
     def test_get_training_code_hash_entry_point_only(self):
         """Test get_training_code_hash with entry_point only"""
         with tempfile.TemporaryDirectory() as temp_dir:
@@ -308,6 +323,20 @@ def test_get_training_code_hash_entry_point_only(self):
             assert len(result_with_deps) == 64
             assert result_no_deps != result_with_deps
 
+    def test_get_training_code_hash_entry_point_only_and_none_dependencies(self):
+        """Test get_training_code_hash with entry_point only and None dependencies does not raise TypeError"""
+        with tempfile.TemporaryDirectory() as temp_dir:
+            entry_file = Path(temp_dir, "train.py")
+            entry_file.write_text("print('training')")
+
+            # This should NOT raise TypeError: can only concatenate list (not "NoneType") to list
+            result = get_training_code_hash(
+                entry_point=str(entry_file), source_dir=None, dependencies=None
+            )
+
+            assert result is not None
+            assert len(result) == 64
+
     def test_get_training_code_hash_s3_uri(self):
         """Test get_training_code_hash with S3 URI returns None"""
         result = get_training_code_hash(
@@ -325,6 +354,77 @@ def test_get_training_code_hash_pipeline_variable(self):
 
             assert result is None
 
+    @pytest.mark.skip(reason="Requires sagemaker-mlops module which is not installed in sagemaker-core tests")
+    def test_get_code_hash_with_training_step_and_no_requirements(self):
+        """Test get_code_hash with TrainingStep where SourceCode has requirements=None"""
+        from sagemaker.mlops.workflow.steps import TrainingStep
+
+        with tempfile.TemporaryDirectory() as temp_dir:
+            entry_file = Path(temp_dir, "train.py")
+            entry_file.write_text("print('training')")
+
+            mock_source_code = Mock()
+            mock_source_code.source_dir = temp_dir
+            mock_source_code.requirements = None  # This is the key: requirements is None
+            mock_source_code.entry_script = str(entry_file)
+
+            mock_model_trainer = Mock()
+            mock_model_trainer.source_code = mock_source_code
+
+            mock_step_args = Mock()
+            mock_step_args.func_args = [mock_model_trainer]
+
+            mock_step = Mock(spec=TrainingStep)
+            mock_step.step_args = mock_step_args
+
+            # This should NOT raise TypeError
+            result = get_code_hash(mock_step)
+
+            assert result is not None
+            assert len(result) == 64
+
+    @pytest.mark.skip(reason="Requires sagemaker-mlops module which is not installed in sagemaker-core tests")
+    def test_get_code_hash_with_training_step_and_requirements(self):
+        """Test get_code_hash with TrainingStep where SourceCode has valid requirements"""
+        from sagemaker.mlops.workflow.steps import TrainingStep
+
+        with tempfile.TemporaryDirectory() as temp_dir:
+            entry_file = Path(temp_dir, "train.py")
+            entry_file.write_text("print('training')")
+            requirements_file = Path(temp_dir, "requirements.txt")
+            requirements_file.write_text("numpy==1.21.0")
+
+            mock_source_code_no_req = Mock()
+            mock_source_code_no_req.source_dir = temp_dir
+            mock_source_code_no_req.requirements = None
+            mock_source_code_no_req.entry_script = str(entry_file)
+
+            mock_source_code_with_req = Mock()
+            mock_source_code_with_req.source_dir = temp_dir
+            mock_source_code_with_req.requirements = str(requirements_file)
+            mock_source_code_with_req.entry_script = str(entry_file)
+
+            mock_model_trainer_no_req = Mock()
+            mock_model_trainer_no_req.source_code = mock_source_code_no_req
+
+            mock_model_trainer_with_req = Mock()
+            mock_model_trainer_with_req.source_code = mock_source_code_with_req
+
+            mock_step_no_req = Mock(spec=TrainingStep)
+            mock_step_no_req.step_args = Mock()
+            mock_step_no_req.step_args.func_args = [mock_model_trainer_no_req]
+
+            mock_step_with_req = Mock(spec=TrainingStep)
+            mock_step_with_req.step_args = Mock()
+            mock_step_with_req.step_args.func_args = [mock_model_trainer_with_req]
+
+            result_no_req = get_code_hash(mock_step_no_req)
+            result_with_req = get_code_hash(mock_step_with_req)
+
+            assert result_no_req is not None
+            assert result_with_req is not None
+            assert result_no_req != result_with_req
+
     def test_validate_step_args_input_valid(self):
         """Test validate_step_args_input with valid input"""
         step_args = _StepArguments(