From 2247f9d187d0c96161b7c08d70b33d0d044f17a6 Mon Sep 17 00:00:00 2001 From: aviruthen <91846056+aviruthen@users.noreply.github.com> Date: Fri, 20 Mar 2026 19:17:40 -0400 Subject: [PATCH] fix: Pipeline TypeError: can only concatenate list (not "NoneType") to list Using Sou (#5518) --- .../src/sagemaker/core/workflow/utilities.py | 1 + .../tests/unit/workflow/test_utilities.py | 76 +++++++++++++++++++ 2 files changed, 77 insertions(+) diff --git a/sagemaker-core/src/sagemaker/core/workflow/utilities.py b/sagemaker-core/src/sagemaker/core/workflow/utilities.py index c07a31c51e..4cf63d3f2c 100644 --- a/sagemaker-core/src/sagemaker/core/workflow/utilities.py +++ b/sagemaker-core/src/sagemaker/core/workflow/utilities.py @@ -197,6 +197,7 @@ def get_processing_dependencies(dependency_args: List[List[str]]) -> List[str]: def get_processing_code_hash(code: str, source_dir: str, dependencies: List[str]) -> str: + dependencies = dependencies or [] """Get the hash of a processing step's code artifact(s). Args: diff --git a/sagemaker-core/tests/unit/workflow/test_utilities.py b/sagemaker-core/tests/unit/workflow/test_utilities.py index 5e9ed7bbbd..154d2c83e6 100644 --- a/sagemaker-core/tests/unit/workflow/test_utilities.py +++ b/sagemaker-core/tests/unit/workflow/test_utilities.py @@ -250,6 +250,53 @@ def test_get_processing_code_hash_s3_uri(self): assert result is None def test_get_processing_code_hash_with_dependencies(self): + + def test_get_processing_code_hash_with_none_dependencies_does_not_raise(self): + """Test get_processing_code_hash with None dependencies does not raise TypeError""" + result = get_processing_code_hash( + code=None, source_dir=None, dependencies=None + ) + assert result is None + + def test_get_processing_code_hash_with_none_dependencies_and_source_dir(self): + """Test get_processing_code_hash with None dependencies and source_dir""" + with tempfile.TemporaryDirectory() as temp_dir: + code_file = Path(temp_dir, "script.py") + code_file.write_text("print('hello')") + + result = get_processing_code_hash( + code=str(code_file), source_dir=temp_dir, dependencies=None + ) + + assert result is not None + assert len(result) == 64 + + def test_get_processing_code_hash_with_none_dependencies_and_code_only(self): + """Test get_processing_code_hash with None dependencies and code only""" + with tempfile.NamedTemporaryFile(mode="w", suffix=".py", delete=False) as f: + f.write("print('hello')") + temp_file = f.name + + try: + result = get_processing_code_hash(code=temp_file, source_dir=None, dependencies=None) + + assert result is not None + assert len(result) == 64 + finally: + os.unlink(temp_file) + + def test_get_processing_code_hash_with_none_dependencies_and_source_dir_and_code(self): + """Test get_processing_code_hash with None dependencies, source_dir and code""" + with tempfile.TemporaryDirectory() as temp_dir: + code_file = Path(temp_dir, "script.py") + code_file.write_text("print('hello')") + + result = get_processing_code_hash( + code=str(code_file), source_dir=temp_dir, dependencies=None + ) + + assert result is not None + assert len(result) == 64 """Test get_processing_code_hash with dependencies""" with tempfile.TemporaryDirectory() as temp_dir: code_file = Path(temp_dir, "script.py") @@ -317,6 +364,35 @@ def test_get_training_code_hash_s3_uri(self): assert result is None def test_get_training_code_hash_pipeline_variable(self): + + def test_get_training_code_hash_with_none_dependencies_and_source_dir(self): + """Test get_training_code_hash with None dependencies and source_dir""" + with tempfile.TemporaryDirectory() as temp_dir: + entry_file = Path(temp_dir, "train.py") + entry_file.write_text("print('training')") + + result = get_training_code_hash( + entry_point=str(entry_file), source_dir=temp_dir, dependencies=None + ) + + assert result is not None + assert len(result) == 64 + + def test_get_training_code_hash_with_none_dependencies_and_entry_point_only(self): + """Test get_training_code_hash with None dependencies and entry_point only""" + with tempfile.NamedTemporaryFile(mode="w", suffix=".py", delete=False) as f: + f.write("print('training')") + temp_file = f.name + + try: + result = get_training_code_hash( + entry_point=temp_file, source_dir=None, dependencies=None + ) + + assert result is not None + assert len(result) == 64 + finally: + os.unlink(temp_file) """Test get_training_code_hash with pipeline variable returns None""" with patch("sagemaker.core.workflow.is_pipeline_variable", return_value=True): result = get_training_code_hash(