Conversation
sagemaker-bot
left a comment
sagemaker-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review
This PR fixes two example notebooks: corrects Session.boto_region_name to Session().boto_region_name (instance vs class attribute), updates MLflow code for v3.x API compatibility, and replaces direct boto3 invoke_endpoint calls with V3-native core_endpoint.invoke(). The changes are well-aligned with V3 SDK conventions.
| " order_by=['version_number DESC'],\n", | ||
| " max_results=1\n", | ||
| ")\n", | ||
| "\n", |
There was a problem hiding this comment.
Minor: The order_by parameter value 'version_number DESC' should be verified against the MLflow search_model_versions API. In some MLflow versions, the supported field name is 'version_number', while in others it may be 'creation_timestamp'. If this notebook targets MLflow 3.x specifically, please confirm this is the correct field name to avoid a runtime error for users.
| "from sagemaker.serve.mode.function_pointers import Mode\n", | ||
| "\n", | ||
| "# Cloud deployment to SageMaker endpoint\n", | ||
| "# Note: 'dependencies' parameter is deprecated. You may see a deprecation warning.\n", |
There was a problem hiding this comment.
Good addition of the deprecation note for the dependencies parameter. However, the comment suggests using configure_for_torchserve() — could you verify this is the correct V3 replacement method name and add a brief code example or link? Users may not know how to apply this guidance.
2 participants
Test PR 3