Skip to content

fix: [Bug] Pipeline parameters (ParameterInteger, ParameterString) fail in ModelTrain (5504)#39

Closed
aviruthen wants to merge 2 commits intomasterfrom
fix/bug-pipeline-parameters-parameterinteger-5504-2
Closed

fix: [Bug] Pipeline parameters (ParameterInteger, ParameterString) fail in ModelTrain (5504)#39
aviruthen wants to merge 2 commits intomasterfrom
fix/bug-pipeline-parameters-parameterinteger-5504-2

Conversation

@aviruthen
Copy link
Copy Markdown
Owner

Description

Fix TypeError in Pipeline.upsert() for invalid role_arn type

Closes #99998

Added type validation at the start of upsert() that raises a clear ValueError with the actual type received.

Related Issue

Related issue: 5504

Changes Made

Pipeline.upsert() needs type validation for role_arn parameter

AI-Generated PR

This PR was automatically generated by the PySDK Issue Agent.

  • Confidence score: 88%
  • Classification: bug
  • SDK version target: V3

Merge Checklist

  • Changes are backward compatible
  • Commit message follows prefix: description format
  • Unit tests added/updated
  • Integration tests added (if applicable)
  • Documentation updated (if applicable)

Copy link
Copy Markdown
Owner Author

@aviruthen aviruthen Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a random comment at the top of the file just as a test comment to see if you can modify this file!

context src/sagemaker/utils.py

@aviruthen
Copy link
Copy Markdown
Owner Author

🤖 Iteration #2 — Review Comments Addressed

Fix TypeError in Pipeline.upsert() for invalid role_arn type

Added type validation at the start of upsert() that raises a clear ValueError with the actual type received when role_arn is not a string.

Also added a test comment at the top of the file per reviewer request to verify file modification capability.

Changes Made

  • src/sagemaker/workflow/pipeline.py: Added test comment at top of file per reviewer feedback. Kept existing role_arn type validation in upsert() method.

Related Issue

Related issue: 5504

Comments reviewed: 1
Files modified: src/sagemaker/workflow/pipeline.py

  • src/sagemaker/workflow/pipeline.py: Add a test comment at the top of the file as requested by reviewer, and keep the existing role_arn validation fix.

@aviruthen aviruthen closed this Apr 7, 2026
@aviruthen aviruthen deleted the fix/bug-pipeline-parameters-parameterinteger-5504-2 branch April 7, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant