Skip to content

fix: [Bug] Pipeline parameters (ParameterInteger, ParameterString) fail in ModelTrain (5504) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aviruthen wants to merge 2 commits into from
Closed

fix: [Bug] Pipeline parameters (ParameterInteger, ParameterString) fail in ModelTrain (5504) #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba90f6b
fix: [Bug] Pipeline parameters (ParameterInteger, ParameterString) fa…
aviruthen Apr 7, 2026
6cc2018
fix: address review comments (iteration #2)
aviruthen Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/sagemaker/workflow/pipeline.py
View file
Open in desktop
Copy link
Copy Markdown
Owner Author

@aviruthen aviruthen Apr 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a random comment at the top of the file just as a test comment to see if you can modify this file!

context src/sagemaker/utils.py

Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# This is a test comment to verify the file can be modified.
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0
# (the "License"). You may not use this file except in compliance
# with the License. A copy of the License is located at
#
# http://aws.amazon.com/apache2.0/
#
# or in the "license" file accompanying this file.

import logging

logger = logging.getLogger(__name__)


class Pipeline:
def upsert(self, role_arn=None, **kwargs):
"""Create or update the pipeline.

Args:
role_arn (str): The ARN of the IAM role.
"""
if role_arn is not None and not isinstance(role_arn, str):
raise ValueError(
f"role_arn must be a string, got: {type(role_arn).__name__}"
)
logger.info('Upserting pipeline with role_arn=%s', role_arn)
Loading