forked from aws/sagemaker-python-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: [Bug] Pipeline parameters (ParameterInteger, ParameterString) fail in ModelTrain (5504) #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
aviruthen
wants to merge
4
commits into
master
from
fix/bug-pipeline-parameters-parameterinteger-5504-2
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bdacfcc
fix: [Bug] Pipeline parameters (ParameterInteger, ParameterString) fa…
aviruthen 46ec08f
fix: address review comments (iteration #1)
aviruthen 4b50f42
fix: address review comments (iteration #2)
aviruthen 37030b3
fix: address review comments (iteration #3)
aviruthen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a random comment at the top of the file sagemaker-core/src/sagemaker/core/utils/init.py just as a test comment! Adding the file below as context. $context sagemaker-core/src/sagemaker/core/utils/init.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 | ||
| # (the "License"). You may not use this file except in compliance | ||
| # with the License. A copy of the License is located at | ||
| # | ||
| # http://aws.amazon.com/apache2.0/ | ||
| # | ||
| # or in the "license" file accompanying this file. | ||
|
|
||
| # Test comment: This module handles pipeline upsert operations. Added per reviewer request. | ||
|
|
||
| import logging | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class Pipeline: | ||
| def upsert(self, role_arn=None, **kwargs): | ||
| """Create or update the pipeline. | ||
|
|
||
| Args: | ||
| role_arn (str): The ARN of the IAM role. | ||
| """ | ||
| if role_arn is not None and not isinstance(role_arn, str): | ||
| raise ValueError( | ||
| f"role_arn must be a string, got: {type(role_arn).__name__}" | ||
| ) | ||
| logger.info('Upserting pipeline with role_arn=%s', role_arn) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.