feat: adds code for showing service event info when using ecs deploy controller#454
feat: adds code for showing service event info when using ecs deploy controller#454felipem1210 wants to merge 1 commit intoaws-actions:masterfrom
Conversation
8b66948 to
91af23e
Compare
|
Hi @felipem1210, Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request. We will reach-out if with any questions or suggestions during the review. In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:
|
|
|
||
| mockEcsDescribeServices.mockImplementation(() => { | ||
| return { | ||
| promise() { |
There was a problem hiding this comment.
The mock needs to be updated as the action is now using JS SDK v3
Refer: #529
There was a problem hiding this comment.
@trivikr I could resolve the conflicts but the tests I implemented are failing, can I have some guidance on how should I correct them? I am more a cloud engineer than a javascript developer, so I am noob where talking about testing code
91af23e to
61fc2fd
Compare
61fc2fd to
bf5bcb3
Compare
|
What needs to happen to get this merged please? We are running into the issue where we have the deployment circuit breaker enabled and am getting a successful return from the action even when the rollback was initiated. This output would help determine issues. |
|
Hello, |
Issue #, if available: #447
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.