Support ARN being passed in as well as a file#658
Support ARN being passed in as well as a file#658LukeSheard wants to merge 2 commits intoaws-actions:masterfrom
Conversation
| let taskDefArn = null; | ||
|
|
||
| // Of taskDefContent starts with arn: then we assume it is a task definition ARN | ||
| if (taskDefinitionContent.startsWith("arn:")) { |
There was a problem hiding this comment.
Thank you for this PR!
I am wondering if it would be a good idea to introduce another variable for taskDefinitionArn instead of re-using existing variable? This could ease error handling by helping us return proper error messages back to users.
We have something similar implemented in the amazon-ecs-render-task-definition repo as well:
https://github.com/aws-actions/amazon-ecs-render-task-definition/blob/master/dist/index.js#L32
There was a problem hiding this comment.
Okay, I will implement it in the equivalent way to the render task definition action.
|
@LukeSheard Thanks for taking the initiative, it would be great to get this change merged 💪 ! |
|
Hey @s3cube - I'm not sure why you re-opened this, but I have no intention of working on this. We agreed in the comments that this PR should take a different direction, so if you still want this feature you should open a new PR based on that feedback! |
4 participants
An up to date version of this PR which should support the AWS SDK v3.