fix: add maxDelay to prevent exponential backoff in waiters#839
Merged
s3cube merged 1 commit intoMar 1, 2026
Merged
Conversation
s3cube
reviewed
Feb 16, 2026
| const waitTaskResponse = await waitUntilTasksStopped({ | ||
| client: ecs, | ||
| minDelay: WAIT_DEFAULT_DELAY_SEC, | ||
| maxDelay: WAIT_DEFAULT_DELAY_SEC, |
Contributor
There was a problem hiding this comment.
Can we keep the default as is, and allow it to be overridden?
Contributor
Author
There was a problem hiding this comment.
Sure, I'll add an optional wait-max-delay-seconds input parameter.
EzgiTastan
force-pushed
the
fix/add-maxdelay-to-prevent-exponential-backoff
branch
from
8682a43 to
6fe2cd9
Compare
Contributor
|
@EzgiTastan , the PR looks good to me. Are you able to update the Package distribution file, we can go ahead and merge it soon after. |
Contributor
Author
|
Hi @s3cube , I've verified locally that the dist/ is up to date. It looks like the failing CI is due to a transient npm registry 403 error, could you please re-run the failed job? |
Contributor
|
Thank you for your contribution @EzgiTastan! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A (new issue discovered)
Description of changes:
Problem
The SDK v3 upgrade (commits a15de3c, b5c6c3f) added
minDelaybut did not addmaxDelayto the waiter options. WithoutmaxDelay, the AWS SDK defaults to 120 seconds, causing exponential backoff between polls:This means even if the ECS service becomes stable quickly, the action may wait up to 2 minutes before the next poll detects it.
Solution
Added
maxDelay: WAIT_DEFAULT_DELAY_SEC(15 seconds) to all three waiters:waitUntilTasksStoppedwaitUntilServicesStablewaitUntilDeploymentSuccessfulThis ensures consistent 15-second polling intervals without exponential backoff.
Testing
dist/index.jswithnpm run packageBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.