Conversation
amazreech
reviewed
Mar 25, 2026
| - name: Node setup | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 |
Contributor
There was a problem hiding this comment.
Curious why a new Node Setup is need for new version but wan't needed for the existing node version?
Contributor
Author
There was a problem hiding this comment.
Primarily parity with the other action + code-build failures at release-time
Contributor
There was a problem hiding this comment.
We have similar setup in render as well: aws-actions/amazon-ecs-render-task-definition@872f52a
amazreech
approved these changes
Mar 25, 2026
| - name: Node setup | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 |
Contributor
There was a problem hiding this comment.
We have similar setup in render as well: aws-actions/amazon-ecs-render-task-definition@872f52a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#845
#846
Description of changes:
Upgrades to Node24
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.