fix: only send volumeConfigurations when EBS inputs are provided#863
Open
wilsonjord wants to merge 1 commit into
Open
fix: only send volumeConfigurations when EBS inputs are provided#863wilsonjord wants to merge 1 commit into
wilsonjord wants to merge 1 commit into
Conversation
omkhegde
approved these changes
Jun 3, 2026
Author
|
@omkhegde thank you for your review. I notice there is a failing check CI "Send Notifications to Slack"...is there anything needed on my part? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Resolves a regression introduced by #721 where the action sent an empty volumeConfigurations array to UpdateService and RunTask when no inputs were provided. AWS interprets the empty array as "clear all volume configurations", rather than "no change", which was the pre-v2.3.0 behaviour.
This new behaviour causes deployment failures for services managed externally (e.g. via Terraform), as externally configured EBS volumes where cleared; EBS configuration to be redundantly declared again in the workflow to avoid this failure.
Fix: only include
volumeConfigurationswhen inputs are provided, otherwise exclude.Tests: removed
volumeConfigurations: []assertions that were based on the buggy behaviour. Deletedremove service EBS volume configurationtest completely, as that behaviour is no longer possible.Behaviour change: currently, users can clear a services's volume configuration by omitting the EBS inputs, which sends an explicit
[]. This fix removes that ability - if desired, I can follow up with the ability for a user to explicitly clear volumes (aservice-managed-ebs-volume-clear-like input).