Skip to content

chore(auth): Move HandleWebUiSignInResponse logic to use case#3241

Merged
mattcreaser merged 1 commit into
mainfrom
mattcreaser/usecase-web-ui-sign-in-response
Mar 24, 2026
Merged

chore(auth): Move HandleWebUiSignInResponse logic to use case#3241
mattcreaser merged 1 commit into
mainfrom
mattcreaser/usecase-web-ui-sign-in-response

Conversation

@mattcreaser
Copy link
Copy Markdown
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Moves callback logic of handleWebUiSignInReponse from RealAWSAuthCognitoPlugin to a usecase
  • Adds code coverage which previously did not exist for this logic.

How did you test these changes?

  • Tests should pass

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner March 23, 2026 16:27
Base automatically changed from mattcreaser/federate-identity-pool-use-case to main March 24, 2026 11:56
@mattcreaser mattcreaser force-pushed the mattcreaser/usecase-web-ui-sign-in-response branch from fc8783c to 1efa1f0 Compare March 24, 2026 11:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.48%. Comparing base (36f7590) to head (1efa1f0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
+ Coverage   55.38%   55.48%   +0.10%     
==========================================
  Files        1077     1078       +1     
  Lines       31905    31911       +6     
  Branches     4756     4757       +1     
==========================================
+ Hits        17670    17706      +36     
+ Misses      12392    12360      -32     
- Partials     1843     1845       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattcreaser mattcreaser enabled auto-merge (squash) March 24, 2026 13:37
@mattcreaser mattcreaser merged commit d09047f into main Mar 24, 2026
19 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/usecase-web-ui-sign-in-response branch March 24, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants