Skip to content

chore(auth): Move hosted UI sign in to use case#3242

Merged
mattcreaser merged 2 commits into
mainfrom
mattcreaser/usecase-web-ui-sign-in
Mar 26, 2026
Merged

chore(auth): Move hosted UI sign in to use case#3242
mattcreaser merged 2 commits into
mainfrom
mattcreaser/usecase-web-ui-sign-in

Conversation

@mattcreaser

Copy link
Copy Markdown
Member
  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • WebUi Sign In logic refactored into coroutine-based usecase
  • Code coverage added

How did you test these changes?

  • Tests should pass

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser
mattcreaser requested a review from a team as a code owner March 24, 2026 14:03
@mattcreaser mattcreaser changed the title Move hosted UI sign in to use case chore(auth): Move hosted UI sign in to use case Mar 24, 2026
@mattcreaser
mattcreaser marked this pull request as draft March 24, 2026 14:15
Base automatically changed from mattcreaser/usecase-web-ui-sign-in-response to main March 24, 2026 22:05
@mattcreaser
mattcreaser force-pushed the mattcreaser/usecase-web-ui-sign-in branch from e765c0d to 38300bc Compare March 25, 2026 16:28
@codecov

codecov Bot commented Mar 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.64%. Comparing base (d09047f) to head (73d8f99).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3242      +/-   ##
==========================================
+ Coverage   55.50%   55.64%   +0.13%     
==========================================
  Files        1078     1079       +1     
  Lines       31911    31858      -53     
  Branches     4757     4751       -6     
==========================================
+ Hits        17711    17726      +15     
+ Misses      12356    12278      -78     
- Partials     1844     1854      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattcreaser
mattcreaser marked this pull request as ready for review March 26, 2026 14:49
@mattcreaser
mattcreaser merged commit c9b0f0f into main Mar 26, 2026
20 checks passed
@mattcreaser
mattcreaser deleted the mattcreaser/usecase-web-ui-sign-in branch March 26, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants