Skip to content

feat(api): add sealed exception hierarchy for api plugin#3279

Merged
mattcreaser merged 19 commits intomainfrom
jv/add-sealed-exception-hierarchy-api-plugin
May 7, 2026
Merged

feat(api): add sealed exception hierarchy for api plugin#3279
mattcreaser merged 19 commits intomainfrom
jv/add-sealed-exception-hierarchy-api-plugin

Conversation

@jvh-aws
Copy link
Copy Markdown
Contributor

@jvh-aws jvh-aws commented Apr 16, 2026

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

Adds sealed exception hierarchy for API plugin enabling exhaustive Kotlin when expressions while maintaining backward compatibility with existing catch blocks.

New types marked @ExperimentalAmplifyApi, opt in with @OptIn(ExperimentalAmplifyApi::class) to use. ApiAuthException made non-final (non-breaking) to allow subclassing; NonRetryableException is otherwise unchanged to avoid a breaking change.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions Bot added the Title Needs Formatting Added by the PR Title Checker when a PR title does not conform to our guidelines label Apr 27, 2026
@jvh-aws jvh-aws changed the title Start adding sealed exception hierarchy for api plugin feat(api): add sealed exception hierarchy for api plugin Apr 27, 2026
@github-actions github-actions Bot removed the Title Needs Formatting Added by the PR Title Checker when a PR title does not conform to our guidelines label Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.93%. Comparing base (1aca347) to head (b44c44e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3279   +/-   ##
=======================================
  Coverage   55.92%   55.93%           
=======================================
  Files        1083     1084    +1     
  Lines       31932    31952   +20     
  Branches     4760     4760           
=======================================
+ Hits        17859    17873   +14     
- Misses      12219    12223    +4     
- Partials     1854     1856    +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jvh-aws jvh-aws marked this pull request as ready for review April 27, 2026 20:04
@jvh-aws jvh-aws requested review from a team as code owners April 27, 2026 20:04
@mattcreaser mattcreaser merged commit 10d1107 into main May 7, 2026
18 of 19 checks passed
@mattcreaser mattcreaser deleted the jv/add-sealed-exception-hierarchy-api-plugin branch May 7, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants