chore: prep migrations release#3169
Merged
Merged
Conversation
dpilch
force-pushed
the
migrations-release
branch
from
a4885d6 to
1f91d69
Compare
dpilch
commented
Mar 10, 2025
| // start block | ||
| // deletion protection is enabled for migrated tables | ||
| // disable deletion protection to teardown the tests | ||
| await Promise.allSettled( |
Contributor
Author
There was a problem hiding this comment.
We actually need this block because the tables will still have deletion protection when tearing down the test.
tejas2008
previously approved these changes
Mar 12, 2025
dpilch
force-pushed
the
migrations-release
branch
from
a87baa1 to
8981707
Compare
sobolk
approved these changes
Apr 14, 2025
svidgen
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
CDK / CloudFormation Parameters Changed
No changes other than removing experimental tags from features.
Issue #, if available
N/A
Description of how you validated changes
E2E tests: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/594813022831/projects/amplify-category-api-e2e-workflow/batch/amplify-category-api-e2e-workflow:8c9ce3b2-4ba0-49cb-b546-8f5fbeef9415?region=us-east-1
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.