fix: add _setupNodeVersion to _setupCDKTestsLinux and _setupE2ETestsLinux#3462
Merged
adrianjoshua-strutt merged 1 commit intoApr 6, 2026
Merged
Conversation
svidgen
approved these changes
Apr 6, 2026
adrianjoshua-strutt
deleted the
fix/add-setupNodeVersion-to-cdk-tests-release
branch
adrianjoshua-strutt
added a commit
that referenced
this pull request
Apr 7, 2026
…inux (#3463) The canary test functions _setupCDKTestsLinux and _setupE2ETestsLinux never called _setupNodeVersion, causing them to run on the Docker image's system Node 18.15.0 instead of the configured AMPLIFY_NODE_VERSION (24.12.0). This worked until lru-cache v11 was published to npm (~Apr 6 2026 00:00 UTC), which requires diagnostics_channel.tracingChannel() (Node 20.5+). This PR adds the missing _setupNodeVersion $AMPLIFY_NODE_VERSION call to both functions in Gen1 as well Companion PRs: - #3461 (main) - #3462 (release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The canary test functions
_setupCDKTestsLinuxand_setupE2ETestsLinuxinshared-scripts.shnever called_setupNodeVersion, causing them to run on the Docker image's system Node 18.15.0 instead of the configuredAMPLIFY_NODE_VERSION(24.12.0).This worked until
lru-cachev11 was published to npm (~Apr 6 2026 00:00 UTC), which requiresdiagnostics_channel.tracingChannel()(available from Node 20.5+). Since CodeBuild was still running Node 18.15.0 in these test steps, the canary builds broke.Result: 83 CloudWatch alarms firing across Amplify Data Canary tests.
Fix
Add the missing
_setupNodeVersion $AMPLIFY_NODE_VERSIONcall to both functions, matching what every other test function inshared-scripts.shalready does._setupE2ETestsLinux: replaced the staleyarn config set ignore-engines trueworkaround with_setupNodeVersion_setupCDKTestsLinux: added_setupNodeVersionafterloadCacheand before_installCLIFromLocalRegistryNotes
releasedirectly because canaries run from thereleasebranch.