Skip to content

fix: add _setupNodeVersion to _setupCDKTestsLinux and _setupE2ETestsLinux#3463

Merged
adrianjoshua-strutt merged 1 commit into
release-api-plugin-stablefrom
fix/add-setupNodeVersion-to-e2e-tests-stable
Apr 7, 2026
Merged

fix: add _setupNodeVersion to _setupCDKTestsLinux and _setupE2ETestsLinux#3463
adrianjoshua-strutt merged 1 commit into
release-api-plugin-stablefrom
fix/add-setupNodeVersion-to-e2e-tests-stable

Conversation

@adrianjoshua-strutt
Copy link
Copy Markdown
Member

@adrianjoshua-strutt adrianjoshua-strutt commented Apr 7, 2026

The canary test functions _setupCDKTestsLinux and _setupE2ETestsLinux never called _setupNodeVersion, causing them to run on the Docker image's system Node 18.15.0 instead of the configured AMPLIFY_NODE_VERSION (24.12.0). This worked until lru-cache v11 was published to npm (~Apr 6 2026 00:00 UTC), which requires diagnostics_channel.tracingChannel() (Node 20.5+).

This PR adds the missing _setupNodeVersion $AMPLIFY_NODE_VERSION call to both functions in Gen1 as well

Companion PRs:

@adrianjoshua-strutt adrianjoshua-strutt requested a review from a team as a code owner April 7, 2026 11:32
@adrianjoshua-strutt adrianjoshua-strutt merged commit 831edd1 into release-api-plugin-stable Apr 7, 2026
6 checks passed
@adrianjoshua-strutt adrianjoshua-strutt deleted the fix/add-setupNodeVersion-to-e2e-tests-stable branch April 7, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants