feat(amplify-category-api): keep datastore fields when disabling datastore#3475
Open
cadivus wants to merge 4 commits intorelease-api-plugin-stablefrom
Open
feat(amplify-category-api): keep datastore fields when disabling datastore#3475cadivus wants to merge 4 commits intorelease-api-plugin-stablefrom
cadivus wants to merge 4 commits intorelease-api-plugin-stablefrom
Conversation
…store Needed to e.g. filter for soft deleted data
adrianjoshua-strutt
requested changes
Apr 29, 2026
| }) => { | ||
| if (node.name.value !== typeName) return undefined; | ||
| for (const field of node.fields ?? []) { | ||
| const scalar = field.type.kind === 'NamedType' && field.type.name ? field.type.name.value : ''; |
Member
There was a problem hiding this comment.
The code only checks field.type.kind === 'NamedType' when detecting existing sync fields. If someone has _version: Int! in their schema, the NonNullType wrapper means it won't be recognized. We should do a recursive check here.
Member
Author
There was a problem hiding this comment.
Does the fix work for you?
…detection test helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to e.g. filter for soft deleted data when disabling datastore
Description of changes
CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.