Skip to content

Commit a514ec7

Browse files
committed
fix(cli): add typescript devDep to fix typecheck for bundler moduleResolution
backend-only and discussions were missing typescript as a devDependency, causing npx tsc to fall back to the root tsc v4.9.5 which doesn't support moduleResolution:"bundler". Also restores monorepo metadata in discussions snapshot package.json files.
1 parent 1aceadb commit a514ec7

File tree

5 files changed

+40
-26
lines changed

5 files changed

+40
-26
lines changed

amplify-migration-apps/backend-only/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,8 @@
99
"scripts": {
1010
"sanitize": "tsx ../sanitize.ts",
1111
"typecheck": "cd _snapshot.post.generate/amplify && npx tsc --noEmit"
12+
},
13+
"devDependencies": {
14+
"typescript": "~5.9.3"
1215
}
1316
}

amplify-migration-apps/discussions/_snapshot.post.generate/package.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,20 @@
11
{
2-
"name": "discussions",
2+
"name": "@amplify-migration-apps/discussions",
33
"private": true,
44
"version": "0.0.0",
55
"type": "module",
6+
"installConfig": {
7+
"hoistingLimits": "workspaces"
8+
},
69
"scripts": {
710
"dev": "vite",
811
"build": "vite build",
912
"preview": "vite preview",
1013
"configure": "./configure.sh",
1114
"configure-schema": "./configure-schema.sh",
12-
"configure-functions": "./configure-functions.sh"
15+
"configure-functions": "./configure-functions.sh",
16+
"sanitize": "tsx ../sanitize.ts",
17+
"typecheck": "cd _snapshot.post.generate/amplify && npx tsc --noEmit"
1318
},
1419
"devDependencies": {
1520
"@aws-amplify/backend": "^1.18.0",

amplify-migration-apps/discussions/_snapshot.pre.generate/package.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,20 @@
11
{
2-
"name": "discussions",
2+
"name": "@amplify-migration-apps/discussions",
33
"private": true,
44
"version": "0.0.0",
55
"type": "module",
6+
"installConfig": {
7+
"hoistingLimits": "workspaces"
8+
},
69
"scripts": {
710
"dev": "vite",
811
"build": "vite build",
912
"preview": "vite preview",
1013
"configure": "./configure.sh",
1114
"configure-schema": "./configure-schema.sh",
12-
"configure-functions": "./configure-functions.sh"
15+
"configure-functions": "./configure-functions.sh",
16+
"sanitize": "tsx ../sanitize.ts",
17+
"typecheck": "cd _snapshot.post.generate/amplify && npx tsc --noEmit"
1318
},
1419
"devDependencies": {
1520
"vite": "^7.2.2"

amplify-migration-apps/discussions/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"typecheck": "cd _snapshot.post.generate/amplify && npx tsc --noEmit"
1818
},
1919
"devDependencies": {
20+
"typescript": "~5.9.3",
2021
"vite": "^7.2.2"
2122
},
2223
"dependencies": {

yarn.lock

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,28 @@ __metadata:
3838
languageName: unknown
3939
linkType: soft
4040

41+
"@amplify-migration-apps/discussions@workspace:amplify-migration-apps/discussions/_snapshot.post.generate":
42+
version: 0.0.0-use.local
43+
resolution: "@amplify-migration-apps/discussions@workspace:amplify-migration-apps/discussions/_snapshot.post.generate"
44+
dependencies:
45+
"@aws-amplify/backend": ^1.18.0
46+
"@aws-amplify/backend-cli": ^1.8.0
47+
"@aws-amplify/backend-data": ^1.6.2
48+
"@aws-sdk/client-dynamodb": ^3.936.0
49+
"@aws-sdk/lib-dynamodb": ^3.936.0
50+
"@types/aws-lambda": ^8.10.92
51+
"@types/node": "*"
52+
aws-amplify: ^6.15.8
53+
aws-cdk: ^2
54+
aws-cdk-lib: ^2
55+
ci-info: ^4.3.1
56+
constructs: ^10.0.0
57+
esbuild: ^0.27.0
58+
tsx: ^4.20.6
59+
vite: ^7.2.2
60+
languageName: unknown
61+
linkType: soft
62+
4163
"@amplify-migration-apps/fitness-goal-tracker@workspace:amplify-migration-apps/fitness-tracker/_snapshot.post.generate":
4264
version: 0.0.0-use.local
4365
resolution: "@amplify-migration-apps/fitness-goal-tracker@workspace:amplify-migration-apps/fitness-tracker/_snapshot.post.generate"
@@ -26674,28 +26696,6 @@ __metadata:
2667426696
languageName: node
2667526697
linkType: hard
2667626698

26677-
"discussions@workspace:amplify-migration-apps/discussions/_snapshot.post.generate":
26678-
version: 0.0.0-use.local
26679-
resolution: "discussions@workspace:amplify-migration-apps/discussions/_snapshot.post.generate"
26680-
dependencies:
26681-
"@aws-amplify/backend": ^1.18.0
26682-
"@aws-amplify/backend-cli": ^1.8.0
26683-
"@aws-amplify/backend-data": ^1.6.2
26684-
"@aws-sdk/client-dynamodb": ^3.936.0
26685-
"@aws-sdk/lib-dynamodb": ^3.936.0
26686-
"@types/aws-lambda": ^8.10.92
26687-
"@types/node": "*"
26688-
aws-amplify: ^6.15.8
26689-
aws-cdk: ^2
26690-
aws-cdk-lib: ^2
26691-
ci-info: ^4.3.1
26692-
constructs: ^10.0.0
26693-
esbuild: ^0.27.0
26694-
tsx: ^4.20.6
26695-
vite: ^7.2.2
26696-
languageName: unknown
26697-
linkType: soft
26698-
2669926699
"dlv@npm:^1.1.3":
2670026700
version: 1.1.3
2670126701
resolution: "dlv@npm:1.1.3"

0 commit comments

Comments
 (0)