Skip to content

fix(migrate-template-gen): return early if output is not Fn:GetAtt or…#14137

Merged
abhi7cr merged 1 commit intomigrationsfrom
gen2-migrations-execute
Mar 13, 2025
Merged

fix(migrate-template-gen): return early if output is not Fn:GetAtt or…#14137
abhi7cr merged 1 commit intomigrationsfrom
gen2-migrations-execute

Conversation

@abhi7cr
Copy link
Copy Markdown
Contributor

@abhi7cr abhi7cr commented Mar 13, 2025

Description of changes

  • Exit early in the output resolver if the template ouput is not of type Ref or Fn::GetAtt. Currently, the resources that are moved over only depend on outputs with these types. So its safe to return early. We can add additional cases if we discover its required during migration
  • At the final step of revert command, delete the current amplify folder (Gen2) and move the backup Gen1 folder (.amplify/migration/amplify) to amplify

Issue #, if available

Description of how you validated changes

ran execute and revert command locally, unit tests.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@abhi7cr abhi7cr requested review from a team as code owners March 13, 2025 20:03
aws-aemilia
aws-aemilia previously approved these changes Mar 13, 2025
@Sanayshah2 Sanayshah2 dismissed aws-aemilia’s stale review March 13, 2025 21:53

Approved from integration tests github account by mistake

@abhi7cr abhi7cr merged commit cdc08b5 into migrations Mar 13, 2025
4 checks passed
@abhi7cr abhi7cr deleted the gen2-migrations-execute branch March 13, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants