fix: add idp codegen and fix a couple of minor bugs#14143
Merged
abhi7cr merged 2 commits intoaws-amplify:migrationsfrom Mar 20, 2025
Merged
fix: add idp codegen and fix a couple of minor bugs#14143abhi7cr merged 2 commits intoaws-amplify:migrationsfrom
abhi7cr merged 2 commits intoaws-amplify:migrationsfrom
Conversation
abhi7cr
reviewed
Mar 20, 2025
|
|
||
| getDefinition = async (): Promise<AuthDefinition | undefined> => { | ||
| const referenceAuth = await this.getReferenceAuth(); | ||
| const authCategory = await this.authCategory(); |
Contributor
There was a problem hiding this comment.
nit: rename authCategory to something like getAuthCategory to differentiate between the variable and method.
abhi7cr
reviewed
Mar 20, 2025
| assert(buildSpec, 'buildSpec not found in the app'); | ||
|
|
||
| await writeToAmplifyYmlFile(amplifyYmlPath, buildSpec); | ||
| if (buildSpec) { |
abhi7cr
reviewed
Mar 20, 2025
| factory.createVariableDeclarationList( | ||
| [ | ||
| factory.createVariableDeclaration( | ||
| factory.createIdentifier('providerSetupResult'), |
Contributor
There was a problem hiding this comment.
nit: move providerSetupResult to a constant since it's used in 2 places.
abhi7cr
reviewed
Mar 20, 2025
| ); | ||
|
|
||
| // Create Object.keys(providerSetupResult).forEach(...) | ||
| const forEachStatement = factory.createExpressionStatement( |
Contributor
There was a problem hiding this comment.
can we move the for loop contents into a separate method to reduce the size of this method?
abhi7cr
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
const providerSetupResult = (backend.auth.stack.node.children.find(child => child.node.id === "amplifyAuth") as any).providerSetupResult; Object.keys(providerSetupResult).forEach(provider => { const providerSetupPropertyValue = providerSetupResult[provider]; if (providerSetupPropertyValue.node && providerSetupPropertyValue.node.id.toLowerCase().endsWith("idp")) { userPoolClient.node.addDependency(providerSetupPropertyValue); } });don't throw an error if buildSpec is not found during getApp call: https://app.asana.com/0/1209548398662250/1209731110320988/f
don't generate auth/resource.ts if authCategory doesn't exist
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.