Merged
Conversation
abhi7cr
reviewed
Apr 16, 2025
| assert(to); | ||
| await executeStackRefactor(from, to); | ||
|
|
||
| let parsedcustomResourceMap: ResourceMapping[] | undefined = undefined; |
Contributor
There was a problem hiding this comment.
rename to parsedCustomResourceMap.
abhi7cr
reviewed
Apr 16, 2025
| type: 'string', | ||
| demandOption: true, | ||
| }) | ||
| .option('customResourceMap', { |
Contributor
There was a problem hiding this comment.
should this be resourceMap to make it more generic after our discussion with Josef ?
abhi7cr
reviewed
Apr 16, 2025
| } | ||
| }); | ||
|
|
||
| const fnGetAttRegExp = new RegExp(`{"${GET_ATT}":\\["(?<LogicalResourceId>\\w+)","(?<AttributeName>\\w+)"]}`, 'g'); |
Contributor
There was a problem hiding this comment.
we can extract the below logic of replacing with physicalIds to a separate method.
Contributor
|
There are few lint errors due to cloud pr failing. I will fix it along with the other comments in my next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Refactored custom resources
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.