Gen2 migrations merge from dev and renames around prepare command and resourceMappings#14177
Merged
abhi7cr merged 42 commits intomigrationsfrom Apr 17, 2025
Merged
Gen2 migrations merge from dev and renames around prepare command and resourceMappings#14177abhi7cr merged 42 commits intomigrationsfrom
abhi7cr merged 42 commits intomigrationsfrom
Conversation
BREAKING CHANGE: Update node to 22
…script chore: update packages that depend on `serialize-javascript`
- @aws-amplify/amplify-app@5.0.41 - @aws-amplify/amplify-category-analytics@5.0.40 - @aws-amplify/amplify-category-auth@3.7.20 - @aws-amplify/amplify-category-geo@3.5.20 - @aws-amplify/amplify-category-interactions@5.1.33 - @aws-amplify/amplify-category-notifications@2.26.30 - @aws-amplify/amplify-category-predictions@5.5.20 - @aws-amplify/amplify-category-storage@5.5.19 - @aws-amplify/cli@13.0.0 - @aws-amplify/cli-internal@13.0.0 - amplify-e2e-tests@4.11.5 - amplify-nodejs-function-runtime-provider@2.5.28 - @aws-amplify/amplify-provider-awscloudformation@8.11.6 - @aws-amplify/amplify-util-mock@5.10.14
…1aa3 chore(release): Merge main into dev
…version-bump chore: bump codegen version to 4.10.3
* fix: lerna update * chore: prettier update * chore: added newlines * chore(release): Publish tagged release 12.14.4-lerna-v8 - @aws-amplify/amplify-app@5.0.42-12.14.4-lerna-v8.0 - @aws-amplify/amplify-appsync-simulator@2.16.12-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-analytics@5.0.41-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-auth@3.7.21-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-custom@3.1.28-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-function@5.7.14-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-geo@3.5.21-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-hosting@3.5.41-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-interactions@5.1.34-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-notifications@2.26.31-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-predictions@5.5.21-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-storage@5.5.20-12.14.4-lerna-v8.0 - @aws-amplify/cli-internal@13.0.1-12.14.4-lerna-v8.0 - @aws-amplify/amplify-cli-core@4.4.1-12.14.4-lerna-v8.0 - @aws-amplify/cli-extensibility-helper@3.0.38-12.14.4-lerna-v8.0 - @aws-amplify/cli@13.0.1-12.14.4-lerna-v8.0 - @aws-amplify/amplify-console-hosting@2.5.38-12.14.4-lerna-v8.0 - @aws-amplify/amplify-console-integration-tests@2.11.22-12.14.4-lerna-v8.0 - @aws-amplify/amplify-container-hosting@2.8.18-12.14.4-lerna-v8.0 - amplify-dotnet-function-runtime-provider@2.1.4-12.14.4-lerna-v8.0 - @aws-amplify/amplify-dotnet-function-template-provider@2.7.4-12.14.4-lerna-v8.0 - amplify-dynamodb-simulator@2.9.23-12.14.4-lerna-v8.0 - @aws-amplify/amplify-e2e-core@5.7.4-12.14.4-lerna-v8.0 - amplify-e2e-tests@4.11.6-12.14.4-lerna-v8.0 - @aws-amplify/amplify-environment-parameters@1.9.19-12.14.4-lerna-v8.0 - @aws-amplify/amplify-frontend-ios@3.7.12-12.14.4-lerna-v8.0 - @aws-amplify/amplify-frontend-javascript@3.10.22-12.14.4-lerna-v8.0 - amplify-go-function-runtime-provider@2.3.51-12.14.4-lerna-v8.0 - @aws-amplify/amplify-graphiql-explorer@2.6.1-12.14.4-lerna-v8.0 - amplify-java-function-runtime-provider@2.3.51-12.14.4-lerna-v8.0 - @aws-amplify/amplify-migration-tests@6.5.5-12.14.4-lerna-v8.0 - amplify-nodejs-function-runtime-provider@2.5.29-12.14.4-lerna-v8.0 - @aws-amplify/amplify-nodejs-function-template-provider@2.10.14-12.14.4-lerna-v8.0 - @aws-amplify/amplify-opensearch-simulator@1.7.19-12.14.4-lerna-v8.0 - @aws-amplify/amplify-provider-awscloudformation@8.11.7-12.14.4-lerna-v8.0 - amplify-python-function-runtime-provider@2.4.51-12.14.4-lerna-v8.0 - @aws-amplify/amplify-util-mock@5.10.15-12.14.4-lerna-v8.0 - @aws-amplify/amplify-util-uibuilder@1.14.19-12.14.4-lerna-v8.0 * Revert "chore(release): Publish tagged release 12.14.4-lerna-v8" This reverts commit b52bcec. --------- Co-authored-by: Shadowcat567 <lvielto@amazon.com> Co-authored-by: aws-amplify-bot <aws@amazon.com>
Bumps [axios](https://github.com/axios/axios) from 1.7.4 to 1.8.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.4...v1.8.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…ripts/axios-1.8.2 chore(deps): bump axios from 1.7.4 to 1.8.2 in /scripts
* chore(deps): bump aws-cdk-lib from 2.177.0 to 2.184.0 Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) from 2.177.0 to 2.184.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.alpha.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.184.0/packages/aws-cdk-lib) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * chore: dedupe * fix that --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kamil Sobol <5849952+sobolk@users.noreply.github.com>
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.1 to 2.1.2. - [Commits](mafintosh/tar-fs@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: tar-fs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) from 2.184.1 to 2.187.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.alpha.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.187.0/packages/aws-cdk-lib) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
BREAKING CHANGE: Update node to 22
* fix: lerna update * chore: prettier update * chore: added newlines * chore(release): Publish tagged release 12.14.4-lerna-v8 - @aws-amplify/amplify-app@5.0.42-12.14.4-lerna-v8.0 - @aws-amplify/amplify-appsync-simulator@2.16.12-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-analytics@5.0.41-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-auth@3.7.21-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-custom@3.1.28-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-function@5.7.14-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-geo@3.5.21-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-hosting@3.5.41-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-interactions@5.1.34-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-notifications@2.26.31-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-predictions@5.5.21-12.14.4-lerna-v8.0 - @aws-amplify/amplify-category-storage@5.5.20-12.14.4-lerna-v8.0 - @aws-amplify/cli-internal@13.0.1-12.14.4-lerna-v8.0 - @aws-amplify/amplify-cli-core@4.4.1-12.14.4-lerna-v8.0 - @aws-amplify/cli-extensibility-helper@3.0.38-12.14.4-lerna-v8.0 - @aws-amplify/cli@13.0.1-12.14.4-lerna-v8.0 - @aws-amplify/amplify-console-hosting@2.5.38-12.14.4-lerna-v8.0 - @aws-amplify/amplify-console-integration-tests@2.11.22-12.14.4-lerna-v8.0 - @aws-amplify/amplify-container-hosting@2.8.18-12.14.4-lerna-v8.0 - amplify-dotnet-function-runtime-provider@2.1.4-12.14.4-lerna-v8.0 - @aws-amplify/amplify-dotnet-function-template-provider@2.7.4-12.14.4-lerna-v8.0 - amplify-dynamodb-simulator@2.9.23-12.14.4-lerna-v8.0 - @aws-amplify/amplify-e2e-core@5.7.4-12.14.4-lerna-v8.0 - amplify-e2e-tests@4.11.6-12.14.4-lerna-v8.0 - @aws-amplify/amplify-environment-parameters@1.9.19-12.14.4-lerna-v8.0 - @aws-amplify/amplify-frontend-ios@3.7.12-12.14.4-lerna-v8.0 - @aws-amplify/amplify-frontend-javascript@3.10.22-12.14.4-lerna-v8.0 - amplify-go-function-runtime-provider@2.3.51-12.14.4-lerna-v8.0 - @aws-amplify/amplify-graphiql-explorer@2.6.1-12.14.4-lerna-v8.0 - amplify-java-function-runtime-provider@2.3.51-12.14.4-lerna-v8.0 - @aws-amplify/amplify-migration-tests@6.5.5-12.14.4-lerna-v8.0 - amplify-nodejs-function-runtime-provider@2.5.29-12.14.4-lerna-v8.0 - @aws-amplify/amplify-nodejs-function-template-provider@2.10.14-12.14.4-lerna-v8.0 - @aws-amplify/amplify-opensearch-simulator@1.7.19-12.14.4-lerna-v8.0 - @aws-amplify/amplify-provider-awscloudformation@8.11.7-12.14.4-lerna-v8.0 - amplify-python-function-runtime-provider@2.4.51-12.14.4-lerna-v8.0 - @aws-amplify/amplify-util-mock@5.10.15-12.14.4-lerna-v8.0 - @aws-amplify/amplify-util-uibuilder@1.14.19-12.14.4-lerna-v8.0 * Revert "chore(release): Publish tagged release 12.14.4-lerna-v8" This reverts commit b52bcec. --------- Co-authored-by: Shadowcat567 <lvielto@amazon.com> Co-authored-by: aws-amplify-bot <aws@amazon.com>
Bumps [axios](https://github.com/axios/axios) from 1.7.4 to 1.8.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.4...v1.8.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
* chore(deps): bump aws-cdk-lib from 2.177.0 to 2.184.0 Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) from 2.177.0 to 2.184.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.alpha.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.184.0/packages/aws-cdk-lib) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * chore: dedupe * fix that --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kamil Sobol <5849952+sobolk@users.noreply.github.com>
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.1 to 2.1.2. - [Commits](mafintosh/tar-fs@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: tar-fs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) from 2.184.1 to 2.187.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.alpha.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.187.0/packages/aws-cdk-lib) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
bzsurbhi
reviewed
Apr 17, 2025
| if (!resourceMappings.startsWith(FILE_PROTOCOL_PREFIX)) { | ||
| throw new Error(`Expected resourceMap to start with ${FILE_PROTOCOL_PREFIX}`); | ||
| } | ||
| const resourceMapPath = resourceMappings.split(FILE_PROTOCOL_PREFIX)[1]; |
There was a problem hiding this comment.
Should we check the length of resourceMappings after split? If length is 2, then we get [1]
If resourceMappings is only file:// then this would fail right?
Contributor
Author
There was a problem hiding this comment.
yup, that's a good validation to fail fast on :)
bzsurbhi
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
customResourceMaptoresourceMappingsto make it more generic.Description of how you validated changes
unit tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.