Skip to content

fix: custom resource error handling, formatting messages#14181

Merged
abhi7cr merged 1 commit intomigrationsfrom
gen2-migrations-execute
Apr 18, 2025
Merged

fix: custom resource error handling, formatting messages#14181
abhi7cr merged 1 commit intomigrationsfrom
gen2-migrations-execute

Conversation

@abhi7cr
Copy link
Copy Markdown
Contributor

@abhi7cr abhi7cr commented Apr 18, 2025

Description of changes

  • Formatting changes:
    • Add space between Gen1 and Gen2 in outputs
    • Use custom to depict moving custom resources instead of the resource logical ids
  • Custom resource conditional error handling based on presence/absence of comments
  • Use single or double quotes in env parameter regex in custom resource file to add default value

Issue #, if available

Description of how you validated changes

ran the prepare and execute commands locally, unit tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@abhi7cr abhi7cr requested review from a team as code owners April 18, 2025 21:45
1.a) Uncomment the following lines in \`amplify/backend.ts\` file
${this.categories.includes('storage') ? s3BucketChanges : ''}
\`\`\`
${
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditionally render the auth related section of README

@abhi7cr abhi7cr merged commit 3c124b9 into migrations Apr 18, 2025
5 checks passed
@abhi7cr abhi7cr deleted the gen2-migrations-execute branch April 18, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants