test: revert gen2 migration e2e test#14190
Merged
abhi7cr merged 1 commit intomigrationsfrom Apr 24, 2025
Merged
Conversation
abhi7cr
changed the title
Sanayshah2
reviewed
Apr 24, 2025
| return undefined; | ||
| throw new Error( | ||
| `All attempts exhausted while getting resource details from CloudControl API for ${typeName} and ${identifier} identifier in ${region} region`, | ||
| ); |
Contributor
There was a problem hiding this comment.
Is the retry in place because it is an SDK call here or some specific reason?
Contributor
Author
There was a problem hiding this comment.
Yeah its more for eventual consistency :) Ideally 1 try should be good, but depends on the resource.
Sanayshah2
reviewed
Apr 24, 2025
| const gen1CategoryStackResource = gen1RootStackResources.find( | ||
| (gen1RootStackResource) => | ||
| gen1RootStackResource.ResourceType === 'AWS::CloudFormation::Stack' && | ||
| gen1RootStackResource.LogicalResourceId?.startsWith(category), |
Contributor
There was a problem hiding this comment.
Question: Are we always sure that the category stack always starts with the category name?
Contributor
Author
There was a problem hiding this comment.
yeah, for CLI supported categories (e.g auth, storage, function, api), it always starts with the category name
Sanayshah2
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Description of how you validated changes
e2e tests that regress revert flow
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.