Skip to content

chore: remove example from velocity#14219

Merged
sobolk merged 1 commit intodevfrom
remove-velocity-example
Jun 18, 2025
Merged

chore: remove example from velocity#14219
sobolk merged 1 commit intodevfrom
remove-velocity-example

Conversation

@sobolk
Copy link
Copy Markdown
Contributor

@sobolk sobolk commented Jun 18, 2025

Description of changes

This resolves dependabot alert against packages/amplify-velocity-template/examples/package.json .

We address this by deleting packages/amplify-velocity-template/examples . This code is not used.

Some context:

  1. packages/amplify-velocity-template is a copy of open source library. It was copied verbatim here feat: add support for testing AppSync API locally #1893 including examples.
  2. We're using it only here
    import { Compile, parse } from 'amplify-velocity-template';
  3. There's no evidence that our code uses velocity examples.

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested review from a team as code owners June 18, 2025 15:51
@sobolk sobolk merged commit 323d8e1 into dev Jun 18, 2025
5 checks passed
@sobolk sobolk deleted the remove-velocity-example branch June 18, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants