refactor: provider-cloudformation and amplify-category-storage#14238
Merged
ShadowCat567 merged 60 commits intodevfrom Oct 3, 2025
Merged
refactor: provider-cloudformation and amplify-category-storage#14238ShadowCat567 merged 60 commits intodevfrom
ShadowCat567 merged 60 commits intodevfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ShadowCat567
commented
Jul 17, 2025
2 tasks
added 12 commits
August 5, 2025 16:21
added 8 commits
September 4, 2025 11:51
7 tasks
svidgen
reviewed
Oct 1, 2025
svidgen
previously approved these changes
Oct 2, 2025
Member
svidgen
left a comment
svidgen
left a comment
There was a problem hiding this comment.
A couple oddities I wouldn't mind seeing some attention on. But, I'm OK to ship as-is if the tests pass.
added 2 commits
October 2, 2025 18:31
svidgen
previously approved these changes
Oct 3, 2025
svidgen
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating:
Changes the way credentials are handled to use the V3-style object instead of the V2-style one.
Updates
@types/nodeto at least Node 20 in all of the places where outdated versions of Node were being used for@types/node-- the entire repo was upgraded to use Node 22 several months ago, not sure why these were overlooked then.Description of how you validated changes
Additional Testing- Proxies
Tested an app with storage, auth, a lambda function, REST API, and graphQL API to ensure that all of them deploy and update properly through a proxy and that updates don't happen when a proxy is turned off (if they are expecting to go through a proxy). Deployment worked as expected.
Additional Testing - Iterative Deployments
Tested making updates that triggered iterative deployments (added and removed indexes and primary keys) and made an update that allow me to test iterative rollback. It does not seem like the migration introduced new issues related to iterative deployments/rollbacks.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.