chore: fix smoke tests#14256
Merged
ShadowCat567 merged 14 commits intodevfrom Sep 16, 2025
Merged
Conversation
mrgrain
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This was a massive pain >:(
The source of our failing Smoke Tests came from Github runners switching the latest from
macos-14tomacos-15. The Swift team had done some preparation for this, so I was able to take their version of Ruby, but I discovered several other issues.Matching version of Ruby that the Swift team uses: aws-amplify/amplify-swift#4045
Starting with
macos-15, github runners for Mac only supports the 3 most recent versions per platform: actions/runner-images#12758 (comment)Swift tests on 16.0 and 16.4 (https://github.com/aws-amplify/amplify-swift/blob/main/.github/workflows/canary.yml), so I upgraded us to use
16.4with theiPhone 16 Pro Max, to match one of their canaries since it would mean I could avoid implementing the-downloadplatformworkaround.I also needed to upgrade fastlane because of this: fastlane/fastlane#22132
Supported iOS versions: actions/runner-images#12739
Successful Smoke test run: https://github.com/aws-amplify/amplify-cli/actions/runs/17752491602
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.