Skip to content

fix: cli throws an error when thirdPartyAuth is enabled, but authProvider is not included #14284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
otaviomacedo merged 1 commit into from
Oct 21, 2025
Merged

fix: cli throws an error when thirdPartyAuth is enabled, but authProvider is not included #14284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions packages/amplify-category-auth/src/__tests__/provider-utils/awscloudformation/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,41 @@ jest.mock('@aws-amplify/amplify-cli-core', () => ({
// mock fns
const pluginInstanceMock = jest.fn();
const loadResourceParametersMock = jest.fn().mockReturnValue({
hostedUIProviderMeta:
'[{"ProviderName":"Facebook","authorize_scopes":"email,public_profile","AttributeMapping":{"email":"email","username":"id"}},{"ProviderName":"LoginWithAmazon","authorize_scopes":"profile profile:user_id","AttributeMapping":{"email":"email","username":"user_id"}},{"ProviderName":"Google","authorize_scopes":"openid email profile","AttributeMapping":{"email":"email","username":"sub"}},{"ProviderName":"SignInWithApple","authorize_scopes":"openid email profile","AttributeMapping":{"email":"email","username":"sub"}}]',
thirdPartyAuth: true, // enable third party auth, but do not include any authProviders. Should not fail.
hostedUIProviderMeta: JSON.stringify([
{
ProviderName: 'Facebook',
authorize_scopes: 'email,public_profile',
AttributeMapping: {
email: 'email',
username: 'id',
},
},
{
ProviderName: 'LoginWithAmazon',
authorize_scopes: 'profile profile:user_id',
AttributeMapping: {
email: 'email',
username: 'user_id',
},
},
{
ProviderName: 'Google',
authorize_scopes: 'openid email profile',
AttributeMapping: {
email: 'email',
username: 'sub',
},
},
{
ProviderName: 'SignInWithApple',
authorize_scopes: 'openid email profile',
AttributeMapping: {
email: 'email',
username: 'sub',
},
},
]),
});
const pluginInstance = {
loadResourceParameters: loadResourceParametersMock,
Expand Down
9 changes: 5 additions & 4 deletions packages/amplify-category-auth/src/provider-utils/awscloudformation/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,8 @@
const requiredParams: string[] = [];

if (previousValues.thirdPartyAuth) {
if (previousValues.authProviders.includes('accounts.google.com')) {
const authProviders = previousValues.authProviders ?? [];
if (authProviders.includes('accounts.google.com')) {
Comment thread Dismissed
requiredParams.push('googleClientId');
if (projectType === 'ios') {
requiredParams.push('googleIos');
Expand All @@ -335,14 +336,14 @@
requiredParams.push('googleAndroid');
}
}
if (previousValues.authProviders.includes('graph.facebook.com')) {
if (authProviders.includes('graph.facebook.com')) {
Comment thread Dismissed
requiredParams.push('facebookAppId');
}
if (previousValues.authProviders.includes('www.amazon.com')) {
if (authProviders.includes('www.amazon.com')) {
Comment thread Dismissed
requiredParams.push('amazonAppId');
}
// eslint-disable-next-line spellcheck/spell-checker
if (previousValues.authProviders.includes('appleid.apple.com')) {
if (authProviders.includes('appleid.apple.com')) {
Comment thread Dismissed
requiredParams.push('appleAppId');
}
}
Expand Down
Loading