feat(gen2-migration): remove Gen 1 name preservation from codegen synthesizer#14317
Merged
dgandhi62 merged 2 commits intoaws-amplify:gen2-migrationfrom Nov 5, 2025
Merged
Conversation
Remove AMPLIFY_GEN_1_ENV_NAME logic and resource name assignments to allow Gen 2 resources to use natural naming. Refactor step will handle resource mapping between Gen 1 and Gen 2 stacks. - Comment out createAmplifyEnvNameLogic() call - Remove userPoolName template literal assignment - Remove identityPoolName template literal assignment - Remove S3 bucketName template literal assignment - Keep configuration extraction for password policies and other settings
iliapolo
changed the title
iliapolo
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the old tool, names were being assigned to user pools, identity pools, and s3 buckets. This resulted in escape hatches being generated in the backend.ts file during migration. However, these names aren't needed to be set. User pools use ids as their primary identifier. Cloudformation auto-names s3 buckets if a custom name isn't provided.
Therefore, in this pr, I remove AMPLIFY_GEN_1_ENV_NAME logic and resource name assignments from the codegen backend synthesizer. This allows gen2 resources to naturally name themselves. The refactor step will handle resource mapping between Gen 1 and Gen 2 stacks.
The main impact of this pr is to improve user experience on running 'generate'.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.