chore(gen2-migration): some QoL improvements#14732
Merged
iliapolo merged 2 commits intogen2-migrationfrom Apr 1, 2026
Merged
Conversation
Update migration-apps README to reference renamed test files (generate.test.ts, refactor.test.ts), simplify snapshot update commands, and add a note about the two-pass update behavior. Remove the .actual.* copy side effect from Snapshot.compare() and add node_modules ignore pattern to Snapshot.update(). Add a completion log line to update(). --- Prompt: commit what i did
9pace
approved these changes
Apr 1, 2026
iliapolo
commented
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Two small fixes to the snapshot test framework:
README path corrections — The migration-apps README referenced old test
file paths (
command-handlers.test.ts,refactor.test.tsunder nested dirs)that were renamed in a previous PR. Updated all references to the current
generate.test.tsandrefactor.test.tsat the top-level test directory.Also added a note about the two-pass snapshot update behavior (first run
writes updated files but still reports failure; second run confirms).
Snapshot.compare cleanup — Removed the
.actual.*copy side effect fromcompare(). This was copying the actual output into the repo on everycomparison, which cluttered the working tree. The diff report already
contains everything needed for debugging.
Snapshot.update fix — Added
node_modulesto the ignore patterns whencopying actual output into the expected snapshot directory. Without this,
node_modulesfrom the temp dir would get copied into the snapshot,bloating the repo. Added a completion log line for visibility.
Issue #, if available
N/A
Description of how you validated changes
Built the
amplify-clipackage successfully (yarn build).Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.