feat(gen2-migration): add decommission step to e2e test flow#14793
Draft
sai-ray wants to merge 1 commit intogen2-migrationfrom
Draft
feat(gen2-migration): add decommission step to e2e test flow#14793sai-ray wants to merge 1 commit intogen2-migrationfrom
sai-ray wants to merge 1 commit intogen2-migrationfrom
Conversation
sai-ray
changed the title
sai-ray
force-pushed
the
sai/e2e-decommission-step
branch
from
220c359 to
f8b4137
Compare
E2E migration flow Wire `gen2-migration decommission` into `App.migrate()` so the E2E system exercises the full migration lifecycle including Gen1 teardown. After the final `testSharedData()`, the flow checks out the Gen1 branch, runs `amplifyPullNonInteractive` to restore `amplify-meta.json` (which is gitignored and missing after branch switch), then runs `decommission` and verifies the Gen2 app still works via `testGen2()`. The `decommission()` method follows the same pattern as the existing `refactor()` — delegates to `runMigrationStep()` with no extra args. The `amplifyPullNonInteractive` call reads the appId from `team-provider-info.json` (which is tracked in git). Apps with `skipRefactor=true` are unaffected since the new calls live after the early return in `migrate()`. E2E runs confirmed the wiring works: `backend-only` and `store-locator` completed the full flow including decommission and post-decommission `testGen2`. --- Prompt: Add decommission step to E2E migration flow after refactor, followed by testGen2() to verify the Gen2 app is self-contained after Gen1 teardown. Run E2Es on all 9 apps in parallel.
sai-ray
force-pushed
the
sai/e2e-decommission-step
branch
from
f8b4137 to
79f03ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Wire
gen2-migration decommissioninto the E2E migration flow so every run exercises the full lifecycle including Gen1 teardown.Issue #, if available
#14790
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.