Skip to content

fix: eslint warnings above hardcoded threshold#14799

Merged
iankhou merged 1 commit intogen2-migrationfrom
iankhou-eslint-warnings
Apr 23, 2026
Merged

fix: eslint warnings above hardcoded threshold#14799
iankhou merged 1 commit intogen2-migrationfrom
iankhou-eslint-warnings

Conversation

@iankhou
Copy link
Copy Markdown
Contributor

@iankhou iankhou commented Apr 23, 2026

Description of changes

In the _lint step of our AmplifyCLI-E2E-Testing CodeBuild job, we run yarn lint-check, which runs yarn eslint . --ext .js,.jsx,.ts,.tsx --max-warnings=750.

With the inclusion of Gen 2 Migration changes, we are at 999 warnings, which is beyond the existing threshold. This change modifies the value passed to --max-warnings to 1500.


✖ 999 problems (0 errors, 999 warnings)
--
 
ESLint found too many warnings (maximum: 750).
 

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iankhou iankhou marked this pull request as ready for review April 23, 2026 13:57
@iankhou iankhou requested a review from a team as a code owner April 23, 2026 13:57
@iankhou iankhou merged commit 38930ed into gen2-migration Apr 23, 2026
4 checks passed
@iankhou iankhou deleted the iankhou-eslint-warnings branch April 23, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants