Skip to content

Commit f8687db

Browse files
committed
chore: remove orphaned foundation files from rebase"
1 parent de55ab5 commit f8687db

24 files changed

Lines changed: 243 additions & 468 deletions
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1-
# Amplify Foundation Dart
1+
# amplify_foundation_dart
22

33
Common types and utilities for Amplify packages.
4+
5+
## Getting Started
6+
7+
### Visit our [Web Site](https://docs.amplify.aws/) to learn more about AWS Amplify.

packages/amplify_foundation/amplify_foundation_dart/dart_test.yaml

Whitespace-only changes.

packages/amplify_foundation/amplify_foundation_dart/example/amplify_foundation_example.dart

Lines changed: 36 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,17 @@ void main() async {
1515
print('End maxCustomization');
1616
}
1717

18-
// Min Customization — register a simple printer sink and use AmplifyLogging
18+
// Min Customization — register a simple printer sink, use AmplifyLogging,
19+
// and create an AWSCredentialsProvider from a Cognito client
1920
Future<void> minCustomization() async {
2021
// Register a console log sink at info level
2122
final logSink = AmplifySimplePrinterLogSink(logLevel: LogLevel.info);
2223
AmplifyLogging.addSink(logSink);
2324

24-
final loggerProvider = AmplifyLoggerProvider(
25-
createLogger: AmplifyLogging.logger,
26-
);
27-
2825
final cognitoConfig = AmplifyCognitoClientConfig(id: 'UserPoolId');
2926

3027
final amplifyCognitoClient = AmplifyCognitoClient(
31-
loggerProvider: loggerProvider,
28+
createLogger: AmplifyLogging.logger,
3229
config: cognitoConfig,
3330
);
3431

@@ -37,22 +34,21 @@ Future<void> minCustomization() async {
3734

3835
final amplifyS3Client = AmplifyS3Client(
3936
awsCredentialsProvider: credentialsProvider,
40-
loggerProvider: loggerProvider,
37+
createLogger: AmplifyLogging.logger,
4138
config: s3Config,
4239
);
4340

4441
final result = await amplifyS3Client.upload('FilePath');
45-
result.handle(
46-
onSuccess: (data) => print('onSuccess - ${data.value}'),
47-
onFailure: (error) => print('onFailure - ${error.message}'),
48-
);
42+
switch (result) {
43+
case Ok(:final value):
44+
print('ok - ${value.value}');
45+
case Error(:final error):
46+
print('error - $error');
47+
}
4948
}
5049

51-
// Max Customization — custom LogSink and LoggerProvider
50+
// Max Customization — custom LogSink and logger factory
5251
class MyLogSink implements LogSink {
53-
@override
54-
final String id = 'my-custom-sink';
55-
5652
@override
5753
bool isEnabled(LogLevel logLevel) => true; // Accept all levels
5854

@@ -75,29 +71,30 @@ Future<void> maxCustomization() async {
7571

7672
// Use a custom sink with a BroadcastLogger
7773
final customSink = MyLogSink();
78-
final loggerProvider = AmplifyLoggerProvider(
79-
createLogger: (name) => BroadcastLogger(name: name, sinks: [customSink]),
80-
);
74+
Logger createLogger(String name) =>
75+
BroadcastLogger(name: name, sinks: [customSink]);
8176

8277
final s3Config = AmplifyS3ClientConfig(id: 'S3BucketId');
8378

8479
final amplifyS3Client = AmplifyS3Client(
8580
awsCredentialsProvider: credentialsProvider,
86-
loggerProvider: loggerProvider,
81+
createLogger: createLogger,
8782
config: s3Config,
8883
);
8984

9085
final result = await amplifyS3Client.upload('FilePath');
91-
result.handle(
92-
onSuccess: (data) => print('onSuccess - ${data.value}'),
93-
onFailure: (error) => print('onFailure - ${error.message}'),
94-
);
86+
switch (result) {
87+
case Ok(:final value):
88+
print('ok - ${value.value}');
89+
case Error(:final error):
90+
print('error - $error');
91+
}
9592
}
9693

9794
// Cognito Client Code
9895
class AmplifyCognitoClientConfig {
9996
AmplifyCognitoClientConfig({required this.id});
100-
String id;
97+
final String id;
10198
}
10299

103100
class CognitoCredentialProvider implements AWSCredentialsProvider {
@@ -108,12 +105,12 @@ class CognitoCredentialProvider implements AWSCredentialsProvider {
108105
}
109106

110107
class AmplifyCognitoClient {
111-
AmplifyCognitoClient({required this.loggerProvider, required this.config});
108+
AmplifyCognitoClient({required this.createLogger, required this.config});
112109

113-
LoggerProvider loggerProvider;
114-
AmplifyCognitoClientConfig config;
110+
final Logger Function(String name) createLogger;
111+
final AmplifyCognitoClientConfig config;
115112

116-
Logger get _logger => loggerProvider.resolve('AmplifyCognitoClient');
113+
Logger get _logger => createLogger('AmplifyCognitoClient');
117114

118115
AWSCredentialsProvider toAWSCredentialsProvider() {
119116
_logger.verbose('Creating CognitoCredentialProvider');
@@ -125,7 +122,7 @@ class AmplifyCognitoClient {
125122
class UnknownAmplifyException extends AmplifyException {
126123
UnknownAmplifyException({super.cause})
127124
: super(
128-
message: 'An unknown error has occured',
125+
message: 'An unknown error has occurred',
129126
recoverySuggestion: 'Please open an issue on the Amplify Github',
130127
);
131128
}
@@ -138,36 +135,33 @@ class UploadResult {
138135

139136
class AmplifyS3ClientConfig {
140137
AmplifyS3ClientConfig({required this.id});
141-
String id;
138+
final String id;
142139
}
143140

144141
class AmplifyS3Client {
145142
AmplifyS3Client({
146143
required this.awsCredentialsProvider,
147-
required this.loggerProvider,
144+
required this.createLogger,
148145
required this.config,
149146
});
150147

151-
AWSCredentialsProvider awsCredentialsProvider;
152-
LoggerProvider loggerProvider;
153-
AmplifyS3ClientConfig config;
148+
final AWSCredentialsProvider awsCredentialsProvider;
149+
final Logger Function(String name) createLogger;
150+
final AmplifyS3ClientConfig config;
154151

155-
Logger get _logger => loggerProvider.resolve('AmplifyS3Client');
152+
Logger get _logger => createLogger('AmplifyS3Client');
156153

157-
Future<Result<UploadResult, AmplifyException>> upload(String file) async {
154+
Future<Result<UploadResult>> upload(String file) async {
158155
try {
159156
_logger.info('upload called with file: $file');
160157

161158
final result = await _upload(file);
162159

163160
_logger.info('someAction returned with: $result');
164-
return Success(result);
165-
} on AmplifyException catch (error, stackTrace) {
166-
_logger.error('Error calling someAction', error, stackTrace);
167-
return Failure(error);
168-
} on Object catch (error, stackTrace) {
161+
return Result.ok(result);
162+
} on Exception catch (error, stackTrace) {
169163
_logger.error('Error calling someAction', error, stackTrace);
170-
return Failure(UnknownAmplifyException(cause: error));
164+
return Result.error(error);
171165
}
172166
}
173167

packages/amplify_foundation/amplify_foundation_dart/lib/amplify_foundation_dart.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,8 @@ export 'package:amplify_foundation_dart/src/logger/log_level.dart';
1717
export 'package:amplify_foundation_dart/src/logger/log_message.dart';
1818
export 'package:amplify_foundation_dart/src/logger/log_sink.dart';
1919
export 'package:amplify_foundation_dart/src/logger/logger.dart';
20-
export 'package:amplify_foundation_dart/src/logger/logger_provider.dart';
2120
// Results
2221
export 'package:amplify_foundation_dart/src/result/result.dart';
23-
export 'package:amplify_foundation_dart/src/result/result_failure_exception.dart';
2422
// Utils
2523
export 'package:amplify_foundation_dart/src/util/globals.dart';
2624
export 'package:amplify_foundation_dart/src/util/print.dart';

packages/amplify_foundation/amplify_foundation_dart/lib/src/amplify_exception/amplify_exception.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ abstract class AmplifyException implements Exception {
2323

2424
@override
2525
String toString() =>
26-
'AmplifyException: $message\nRecovery suggestion: $recoverySuggestion';
26+
'$runtimeType: $message\nRecovery suggestion: $recoverySuggestion';
2727
}

packages/amplify_foundation/amplify_foundation_dart/lib/src/logger/amplify_logging.dart

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,26 @@ import 'package:amplify_foundation_dart/src/logger/logger.dart';
1515
final class AmplifyLogging {
1616
AmplifyLogging._();
1717

18-
static final Map<String, LogSink> _registeredLogSinks = {};
18+
static final Set<LogSink> _registeredLogSinks = {};
1919

2020
/// Adds a [LogSink] to receive log messages.
2121
static void addSink(LogSink logSink) {
22-
_registeredLogSinks[logSink.id] = logSink;
22+
_registeredLogSinks.add(logSink);
2323
}
2424

2525
/// Removes a previously registered [LogSink].
2626
static void removeSink(LogSink logSink) {
27-
_registeredLogSinks.remove(logSink.id);
27+
_registeredLogSinks.remove(logSink);
2828
}
2929

3030
/// Creates a named [Logger] that broadcasts to all registered sinks.
31+
///
32+
/// Returns a logger bound to the sinks registered at the time of the call.
33+
/// Sinks added later will not affect previously created loggers.
3134
static Logger logger(String name) {
3235
return BroadcastLogger(
3336
name: name,
34-
sinks: List.unmodifiable(_registeredLogSinks.values),
37+
sinks: List.unmodifiable(_registeredLogSinks),
3538
);
3639
}
3740
}

packages/amplify_foundation/amplify_foundation_dart/lib/src/logger/amplify_simple_printer_log_sink.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import 'package:amplify_foundation_dart/src/logger/log_level.dart';
55
import 'package:amplify_foundation_dart/src/logger/log_message.dart';
66
import 'package:amplify_foundation_dart/src/logger/log_sink.dart';
77
import 'package:amplify_foundation_dart/src/util/print.dart';
8-
import 'package:uuid/uuid.dart';
98

109
/// {@template amplify_foundation_dart.amplify_simple_printer_log_sink}
1110
/// A [LogSink] implementation that prints log messages to the console.
@@ -15,11 +14,7 @@ import 'package:uuid/uuid.dart';
1514
/// {@endtemplate}
1615
final class AmplifySimplePrinterLogSink implements LogSink {
1716
/// {@macro amplify_foundation_dart.amplify_simple_printer_log_sink}
18-
AmplifySimplePrinterLogSink({required this.logLevel})
19-
: id = 'AmplifySimplePrinterLogSink-${const Uuid().v4()}';
20-
21-
@override
22-
final String id;
17+
AmplifySimplePrinterLogSink({required this.logLevel});
2318

2419
/// The maximum log level that this sink will emit.
2520
final LogLevel logLevel;

packages/amplify_foundation/amplify_foundation_dart/lib/src/logger/broadcast_logger.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ final class BroadcastLogger implements Logger {
6262
stackTrace: stackTrace,
6363
);
6464
for (final sink in sinks) {
65-
sink.emit(logMessage);
65+
if (sink.isEnabled(logLevel)) {
66+
sink.emit(logMessage);
67+
}
6668
}
6769
}
6870
}

packages/amplify_foundation/amplify_foundation_dart/lib/src/logger/log_level.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ enum LogLevel implements Comparable<LogLevel> {
3434
@override
3535
int compareTo(LogLevel other) => value.compareTo(other.value);
3636

37-
/// Returns true if [other] is less than or equal to this level.
37+
/// Returns true if this level is strictly less than [other].
3838
bool operator <(LogLevel other) => value < other.value;
3939

40-
/// Returns true if [other] is less than or equal to this level.
40+
/// Returns true if this level is less than or equal to [other].
4141
bool operator <=(LogLevel other) => value <= other.value;
4242

43-
/// Returns true if [other] is greater than this level.
43+
/// Returns true if this level is strictly greater than [other].
4444
bool operator >(LogLevel other) => value > other.value;
4545

46-
/// Returns true if [other] is greater than or equal to this level.
46+
/// Returns true if this level is greater than or equal to [other].
4747
bool operator >=(LogLevel other) => value >= other.value;
4848
}

packages/amplify_foundation/amplify_foundation_dart/lib/src/logger/log_message.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import 'package:amplify_foundation_dart/amplify_foundation_dart.dart';
55

66
/// {@template amplify_foundation_dart.log_message}
7-
/// A struct representing a single log message.
7+
/// A class representing a single log message.
88
/// {@endtemplate}
99
final class LogMessage {
1010
/// {@macro amplify_foundation_dart.log_message}

0 commit comments

Comments
 (0)