feat(firehose): add exceptions and record storage types#6828
Open
ekjotmultani wants to merge 1 commit intofeat/amplify-firehose-clientfrom
Open
feat(firehose): add exceptions and record storage types#6828ekjotmultani wants to merge 1 commit intofeat/amplify-firehose-clientfrom
ekjotmultani wants to merge 1 commit intofeat/amplify-firehose-clientfrom
Conversation
…yRecordStorage, and tests"
ekjotmultani
force-pushed
the
feat/firehose-exceptions-storage
branch
from
09771cb to
24b809a
Compare
ekjotmultani
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/amplify-firehose-client #6828 +/- ##
=============================================================
Coverage 43.23% 43.23%
=============================================================
Files 99 99
Lines 7769 7769
Branches 3400 3400
=============================================================
Hits 3359 3359
Misses 4410 4410 🚀 New features to boost your workflow:
|
jvh-aws
reviewed
Mar 25, 2026
| @@ -0,0 +1,156 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
Can we avoid re-implementing those for the firehose client?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the exceptions and record storage objects for use in future prs and the web in-memory impl
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.