Feat/record cache extraction#6839
Draft
ekjotmultani wants to merge 4 commits intofeat/amplify-firehose-client-featurefrom
Draft
Feat/record cache extraction#6839ekjotmultani wants to merge 4 commits intofeat/amplify-firehose-client-featurefrom
ekjotmultani wants to merge 4 commits intofeat/amplify-firehose-client-featurefrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/amplify-firehose-client #6839 +/- ##
=============================================================
Coverage 43.23% 43.23%
=============================================================
Files 99 99
Lines 7769 7769
Branches 3400 3400
=============================================================
Hits 3359 3359
Misses 4410 4410 🚀 New features to boost your workflow:
|
ekjotmultani
force-pushed
the
feat/record-cache-extraction
branch
3 times, most recently
from
e43a418 to
24e1cfe
Compare
Create the Dart-only Firehose client package with: - pubspec.yaml (SDK ^3.9.0, matching KDS dependency set) - sdk.yaml for PutRecordBatch operation - Generated Smithy SDK client (firehose_client, models, serializers) - Firehose API limits (500 records, 1000 KB/record, 4 MB/batch) - version.dart, analysis_options, dart_test.yaml, .gitignore - Skeleton barrel export (amplify_firehose_dart.dart) - Register Firehose component in root pubspec.yaml No business logic yet — just the compilable package shell. Analyzes cleanly with `dart analyze`."
…che_dart Create amplify_record_cache_dart package with shared caching infrastructure: - RecordCacheException hierarchy (const constructors) - Record/RecordInput models (partitionKey optional, dataSize caller-computed) - RecordStorage base + SqliteRecordStorage, InMemoryRecordStorage, IndexedDbRecordStorage - RecordCacheDatabase (Drift, parameterized dbPrefix) - Sender interface + SendResult (replaces KDS-specific PutRecordsResult) - RecordClient, AutoFlushScheduler, FlushStrategy, FlushData, RecordData, ClearCacheData - Platform resolution (VM/web/stub conditional exports) Update amplify_kinesis_dart to depend on shared package: - KinesisSender implements Sender interface (sendBatch replaces putRecords) - Partition key validation moved from RecordStorage to AmplifyKinesisClient - createKinesisRecordInputNow computes dataSize with partition key - All test imports updated, zero behavioral change
The aft generate workflows command regenerated the entire dependabot.yaml with entries for many unrelated packages. Reverting to keep this PR scoped to the record cache extraction only.
ekjotmultani
force-pushed
the
feat/record-cache-extraction
branch
from
24e1cfe to
31e487b
Compare
…lation The barrel file was unconditionally exporting record_storage_indexeddb.dart which imports dart:js_interop. This caused VM tests to fail with "Dart library 'dart:js_interop' is not available on this platform". IndexedDB storage is only reachable through the platform conditional export (record_storage_platform_web.dart), not the barrel.
ekjotmultani
changed the base branch from
feat/amplify-firehose-client
to
feat/amplify-firehose-client-feature
ekjotmultani
force-pushed
the
feat/amplify-firehose-client-feature
branch
3 times, most recently
from
a1791c7 to
ebd1bf8
Compare
ekjotmultani
force-pushed
the
feat/amplify-firehose-client-feature
branch
from
f8acaf2 to
02cde75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.